linux-kernel - Re: [PATCH] dma: idxd: cdev: Fix uninitialized use of sva in idxd_cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2583756c-ff50-4ad6-a280-525cea073b47@gmail.com>
Date: Fri, 18 Apr 2025 14:03:45 +0530
From: Purva Yeshi <purvayeshi550@...il.com>
To: Vinod Koul <vkoul@...nel.org>, vinicius.gomes@...el.com,
 dave.jiang@...el.com
Cc: dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma: idxd: cdev: Fix uninitialized use of sva in
 idxd_cdev_open

On 17/04/25 20:48, Vinod Koul wrote:
> 
> On Thu, 10 Apr 2025 16:32:16 +0530, Purva Yeshi wrote:
>> Fix Smatch-detected issue:
>> drivers/dma/idxd/cdev.c:321 idxd_cdev_open() error:
>> uninitialized symbol 'sva'.
>>
>> 'sva' pointer may be used uninitialized in error handling paths.
>> Specifically, if PASID support is enabled and iommu_sva_bind_device()
>> returns an error, the code jumps to the cleanup label and attempts to
>> call iommu_sva_unbind_device(sva) without ensuring that sva was
>> successfully assigned. This triggers a Smatch warning about an
>> uninitialized symbol.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] dma: idxd: cdev: Fix uninitialized use of sva in idxd_cdev_open
>        commit: 97994333de2b8062d2df4e6ce0dc65c2dc0f40dc
> 
> Best regards,

Hi Vinod,

Thank you for applying the patch!

Best regards,
Purva