linux-kernel - Re: [PATCH v3 03/15] arm64: dts: freescale: imx93-phycore-som: Disable LED pull-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63ba0243-ae07-4e8a-beb3-447e903ba9fc@norik.com>
Date: Fri, 18 Apr 2025 11:18:20 +0200
From: Primoz Fiser <primoz.fiser@...ik.com>
To: Dirk Gouders <dirk@...ders.net>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, upstream@...ts.phytec.de
Subject: Re: [PATCH v3 03/15] arm64: dts: freescale: imx93-phycore-som:
 Disable LED pull-up

Hi Dirk,

On 18. 04. 25 10:16, Dirk Gouders wrote:
> Primoz Fiser <primoz.fiser@...ik.com> writes:
> 
>> There is already an external pull-down resistor on the LED output line.
>> It makes no sense to have both pull-down and pull-up resistors enabled
>> at the same time. Thus disable the internal pull-down.
>                          ~~~~~~~              ~~~~~~~~~
> Sorry for disturbing, but I couldn't resist: the above somehow
> contradicts the subject line -- at least when reading this just by
> chance.

Yeah... it should say "disable the internal pull-up".

Great attention to details :)

Thanks,

BR,
Primoz

> 
> Regards,
> 
> Dirk