linux-kernel - Re: [PATCH 6/8] iio: imu: adis16550: align buffers for timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ba8def4eb147e0224bb82795aa8b01abb11c086.camel@gmail.com>
Date: Fri, 18 Apr 2025 10:17:46 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: David Lechner <dlechner@...libre.com>, Jonathan Cameron
	 <Jonathan.Cameron@...wei.com>
Cc: Andy Shevchenko <andy@...nel.org>, Jonathan Cameron <jic23@...nel.org>, 
 Nuno Sá <nuno.sa@...log.com>, Matthias Brugger
 <matthias.bgg@...il.com>,  AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Cosmin
 Tanislav <cosmin.tanislav@...log.com>,  Tomasz Duszynski
 <tduszyns@...il.com>, Jean-Baptiste Maneyrol
 <jean-baptiste.maneyrol@....com>, Andreas Klinger <ak@...klinger.de>, Petre
 Rodan <petre.rodan@...dimension.ro>,  linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 6/8] iio: imu: adis16550: align buffers for timestamp

On Thu, 2025-04-17 at 15:48 -0500, David Lechner wrote:
> On 4/17/25 12:44 PM, Jonathan Cameron wrote:
> > On Thu, 17 Apr 2025 12:07:37 -0500
> > David Lechner <dlechner@...libre.com> wrote:
> > 
> > > On 4/17/25 11:59 AM, Andy Shevchenko wrote:
> > > > On Thu, Apr 17, 2025 at 11:52:38AM -0500, David Lechner wrote:  
> > > > > Align the buffers used with iio_push_to_buffers_with_timestamp() to
> > > > > ensure the s64 timestamp is aligned to 8 bytes.
> > > > > 
> > > > >  drivers/iio/accel/bmc150-accel.h | 2 +-
> > > > >  drivers/iio/imu/adis16550.c      | 2 +-  
> > > > 
> > > > Looks like a stray squash of the two independent commits.  
> > > 
> > > Oops, sure enough.
> > > 
> > > > 
> > > > ...
> > > >   
> > > > >  	struct bmc150_accel_trigger triggers[BMC150_ACCEL_TRIGGERS];
> > > > >  	struct mutex mutex;
> > > > >  	u8 fifo_mode, watermark;
> > > > > -	s16 buffer[8];
> > > > > +	s16 buffer[8] __aligned(8);  
> > > > 
> > > > As for the code, would it be possible to convert to actually use a sturcture
> > > > rather than an array?  
> > > 
> > > I do personally prefer the struct pattern, but there are very many other
> > > drivers
> > > using this buffer pattern that I was not tempted to try to start converting
> > > them.
> > 
> > For drivers like this one where there is no room for the timestamp
> > to sit earlier for minimal channels I think it is worth that conversion
> > if we are touching them anyway. 
> > 
> > Jonathan
> > 
> There is actually a lot more wrong in this driver, so will save that for a
> separate series.
> 

I think one of them is actually leaking some memory into userspace...

- Nuno Sá