linux-kernel - Re: [PATCH 5/8] staging: sm750fb: rename sii164_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025041825-ranting-dancing-0c86@gregkh>
Date: Fri, 18 Apr 2025 12:34:52 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Ruben Wauters <rubenru09@....com>
Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Teddy Wang <teddy.wang@...iconmotion.com>,
	Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] staging: sm750fb: rename sii164_set_power's param

On Thu, Apr 17, 2025 at 08:02:53PM +0100, Ruben Wauters wrote:
> Renames sii164_set_power's param from powerUp to power
> 
> This fixes checkpatch.pl's camel case check
> 
> Signed-off-by: Ruben Wauters <rubenru09@....com>
> ---
>  drivers/staging/sm750fb/ddk750_sii164.c | 6 +++---
>  drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 9f660a9be5d6..e2da110fab81 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -262,14 +262,14 @@ char *sii164_get_chip_string(void)
>   *      This function sets the power configuration of the DVI Controller Chip.
>   *
>   *  Input:
> - *      powerUp - Flag to set the power down or up
> + *      power - Flag to set the power down or up

But now we don't know if it's "up" or "down", right?  Why not pick
"power_up"?

And shouldn't this be a boolean, and not an unsigned char?

thanks,

greg k-h