linux-kernel - Re: [PATCH v2 1/2] mm/rmap: rename page__anon_vma to page_anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9490ed5c-f6e0-40f3-839b-7b3a5decb5f4@redhat.com>
Date: Fri, 18 Apr 2025 12:40:10 +0200
From: David Hildenbrand <david@...hat.com>
To: Ye Liu <ye.liu@...ux.dev>, akpm@...ux-foundation.org,
 nao.horiguchi@...il.com, linmiaohe@...wei.com
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, harry.yoo@...cle.com,
 riel@...riel.com, vbabka@...e.cz, liuye@...inos.cn
Subject: Re: [PATCH v2 1/2] mm/rmap: rename page__anon_vma to page_anon_vma
 for consistency

On 18.04.25 11:55, Ye Liu wrote:
> From: Ye Liu <liuye@...inos.cn>
> 
> Renamed local variable page__anon_vma in page_address_in_vma() to
> page_anon_vma. The previous naming convention of using double underscores
> (__) is unnecessary and inconsistent with typical kernel style, which uses
> single underscores to denote local variables. Also updated comments to
> reflect the new variable name.
> 
> Functionality unchanged.
> 
> Signed-off-by: Ye Liu <liuye@...inos.cn>
> ---
>   mm/rmap.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 67bb273dfb80..b509c226e50d 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -789,13 +789,13 @@ unsigned long page_address_in_vma(const struct folio *folio,
>   		const struct page *page, const struct vm_area_struct *vma)
>   {
>   	if (folio_test_anon(folio)) {
> -		struct anon_vma *page__anon_vma = folio_anon_vma(folio);
> +		struct anon_vma *page_anon_vma = folio_anon_vma(folio);

I'm extremely confused why this should not simply be called "anon_vma". 
Why do we need the "page" in here *at all* ?

-- 
Cheers,

David / dhildenb