linux-kernel - Re: [PATCH -tip v2 1/2] x86/boot: Remove semicolon from "rep" prefixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4fb6d880-3d5f-4d42-8419-dcc697949a10@citrix.com>
Date: Fri, 18 Apr 2025 12:20:13 +0100
From: Andrew Cooper <andrew.cooper3@...rix.com>
To: Uros Bizjak <ubizjak@...il.com>
Cc: x86@...nel.org, linux-video@...ey.karlin.mff.cuni.cz,
 xen-devel@...ts.xenproject.org, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>,
 Martin Mares <mj@....cz>
Subject: Re: [PATCH -tip v2 1/2] x86/boot: Remove semicolon from "rep"
 prefixes

On 18/04/2025 12:15 pm, Uros Bizjak wrote:
> On Fri, Apr 18, 2025 at 12:24 PM Andrew Cooper
> <andrew.cooper3@...rix.com> wrote:
>> On 18/04/2025 8:13 am, Uros Bizjak wrote:
>>> diff --git a/arch/x86/boot/video.c b/arch/x86/boot/video.c
>>> index f2e96905b3fe..0641c8c46aee 100644
>>> --- a/arch/x86/boot/video.c
>>> +++ b/arch/x86/boot/video.c
>>> @@ -292,7 +292,7 @@ static void restore_screen(void)
>>>                            "shrw %%cx ; "
>>>                            "jnc 1f ; "
>>>                            "stosw \n\t"
>>> -                          "1: rep;stosl ; "
>>> +                          "1: rep stosl ; "
>>>                            "popw %%es"
>> Doesn't this one still need a separator between STOSL and POPW ?
> ";" is a separator as well.

Yes, it is.  I've clearly not had enough coffee yet.  Sorry for the noise.

~Andrew