linux-kernel - Re: [PATCH net-next v5 07/11] net: ti: prueth: Adds support for network filters for traffic control supported by PRU-ICSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2126437499.1093120.1744979157393.JavaMail.zimbra@couthit.local>
Date: Fri, 18 Apr 2025 17:55:57 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: horms <horms@...nel.org>
Cc: parvathi <parvathi@...thit.com>, danishanwar <danishanwar@...com>, 
	rogerq <rogerq@...nel.org>, andrew+netdev <andrew+netdev@...n.ch>, 
	davem <davem@...emloft.net>, edumazet <edumazet@...gle.com>, 
	kuba <kuba@...nel.org>, pabeni <pabeni@...hat.com>, 
	robh <robh@...nel.org>, krzk+dt <krzk+dt@...nel.org>, 
	conor+dt <conor+dt@...nel.org>, nm <nm@...com>, 
	ssantosh <ssantosh@...nel.org>, tony <tony@...mide.com>, 
	richardcochran <richardcochran@...il.com>, 
	glaroque <glaroque@...libre.com>, schnelle <schnelle@...ux.ibm.com>, 
	m-karicheri2 <m-karicheri2@...com>, s hauer <s.hauer@...gutronix.de>, 
	rdunlap <rdunlap@...radead.org>, diogo ivo <diogo.ivo@...mens.com>, 
	basharath <basharath@...thit.com>, 
	jacob e keller <jacob.e.keller@...el.com>, 
	m-malladi <m-malladi@...com>, 
	javier carrasco cruz <javier.carrasco.cruz@...il.com>, 
	afd <afd@...com>, s-anna <s-anna@...com>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	netdev <netdev@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	pratheesh <pratheesh@...com>, Prajith Jayarajan <prajith@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>, 
	mohan <mohan@...thit.com>
Subject: Re: [PATCH net-next v5 07/11] net: ti: prueth: Adds support for
 network filters for traffic control supported by PRU-ICSS

Hi,

> On Mon, Apr 14, 2025 at 06:32:33PM +0530, Parvathi Pudi wrote:
>> From: Roger Quadros <rogerq@...com>
>> 
>> Driver updates to enable/disable network filters and traffic control
>> features supported by the firmware running on PRU-ICSS.
>> 
>> Control of the following features are now supported:
>> 1. Promiscuous mode
>> 2. Network Storm prevention
>> 3. Multicast filtering and
>> 4. VLAN filtering
>> 
>> Firmware running on PRU-ICSS will go through all these filter checks
>> prior to sending the rx packets to the host.
>> 
>> Ethtool or dev ioctl can be used to enable/disable these features from
>> the user space.
>> 
>> Signed-off-by: Roger Quadros <rogerq@...com>
>> Signed-off-by: Andrew F. Davis <afd@...com>
>> Signed-off-by: Basharath Hussain Khaja <basharath@...thit.com>
>> Signed-off-by: Parvathi Pudi <parvathi@...thit.com>
> 
> ...
> 
>> diff --git a/drivers/net/ethernet/ti/icssm/icssm_prueth_dos.c
>> b/drivers/net/ethernet/ti/icssm/icssm_prueth_dos.c
> 
> ...
> 
>> +static int icssm_emac_configure_clsflower(struct prueth_emac *emac,
>> +					  struct flow_cls_offload *cls)
>> +{
>> +	struct flow_rule *rule = flow_cls_offload_flow_rule(cls);
>> +	struct netlink_ext_ack *extack = cls->common.extack;
>> +	const struct flow_action_entry *act;
>> +	int i;
>> +
>> +	flow_action_for_each(i, act, &rule->action) {
>> +		switch (act->id) {
>> +		case FLOW_ACTION_POLICE:
>> +			return icssm_emac_flower_parse_policer
>> +				(emac, extack, cls,
>> +				 act->police.rate_bytes_ps);
>> +		default:
>> +			NL_SET_ERR_MSG_MOD(extack,
>> +					   "Action not supported");
>> +			return -EOPNOTSUPP;
>> +		}
>> +	}
>> +	return -EOPNOTSUPP;
> 
> nit: This line cannot be reached.
>     I think you can just remove it.
> 
>     Flagged by Smatch.
> 

We will cleanup this in the next version.

Thanks and Regards,
Parvathi.