linux-kernel - Re: [PATCH] openrisc: Fix build warning in cache.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64beb3b4-a8fa-4acd-a139-6c19de0e37f4@gmail.com>
Date: Fri, 18 Apr 2025 18:04:29 +0530
From: Sahil Siddiq <icegambit91@...il.com>
To: Stafford Horne <shorne@...il.com>
Cc: jonas@...thpole.se, stefan.kristiansson@...nalahti.fi,
 sahilcdq@...ton.me, linux-openrisc@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] openrisc: Fix build warning in cache.c

Hi,

On 4/18/25 3:30 PM, Stafford Horne wrote:
> On Fri, Apr 18, 2025 at 02:42:20PM +0530, Sahil Siddiq wrote:
>> On 4/18/25 1:17 PM, Stafford Horne wrote:
>>> On Fri, Apr 04, 2025 at 10:39:22AM +0530, Sahil Siddiq wrote:
>>> [...]
>>> I was working on getting this patches ready for upstreaming and noticed one
>>> thing:
>>>
>>>       ---------------------------------------------------------------------------------------
>>>       ./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch
>>>       ---------------------------------------------------------------------------------------
>>>       WARNING: From:/Signed-off-by: email address mismatch: 'From: Sahil Siddiq <icegambit91@...il.com>' != 'Signed-off-by: Sahil Siddiq <sahilcdq@...ton.me>'
>>>
>>>       total: 0 errors, 1 warnings, 102 lines checked
>>>
>>> As you can see above the scripts/checkpatch.pl is failing with the warning
>>> about your email and signed-off-by not matching.  You can see more about it
>>> in the FROM_SIGN_OFF_MISMATCH section of the checkpatch[0] docs.
>>
>> Ok, this makes sense. I configured git-send-email to use gmail because
>> protonmail does not work with git-send-email without a paid account.
>>
>>> How would you like to resolve this?
>>
>> Is this a warning that cannot be ignored? I can:
>>
>> 1. submit the patch series with another email address that won't have issues
>>     with git-send-email, or
>> 2. submit the patch series using protonmail's web client (which might not be
>>     the best option).
>>
>> I would prefer not to use "icegambit91" in the signed-off-by tag.
>>
>> What are your thoughts on this?
> 
> I could rewrite the from header to match sahilcdq@...ton.me.
> 
> But if I do that you should find a way to get proton.me to work with
> gi-send-email [0] for future commits.  It seems this can work using the
> Protonmail Bridge[1], though this site also says proton.me is not so good for
> using with git send email.

Right. Also, protonmail bridge requires a paid proton account.

> Maybe using another email in signed-off-by would be better.  The current
> patches are on linux-next[2] where we can see the From/Signed-off-by mismatch.
> For example:
> 
>      author	Sahil Siddiq <icegambit91@...il.com>	2025-03-29 15:16:22 +0530
>      committer	Stafford Horne <shorne@...il.com>	2025-03-29 10:22:21 +0000
>      commit	af83ece87a1ef5097434b7c3c1fc0e9e7b83b192 (patch)
> 
>      ...
> 
>      Signed-off-by: Sahil Siddiq <sahilcdq@...ton.me>
>      Signed-off-by: Stafford Horne <shorne@...il.com>
> 

I agree. I have another email id (sahilcdq0@...il.com). I can configure git
to use this and this can also be used in the signed-off-by tag. So, this id
shouldn't cause an issue.

Let me know if I should send the series using this email id.

Thanks,
Sahil