linux-kernel - RE: [PATCH] HID: intel-thc-hid: intel-quicki2c: pass correct arguments to acpi_evaluate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB609853AC82FFA8D7B4006E5BF4BF2@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Fri, 18 Apr 2025 02:05:35 +0000
From: "Xu, Even" <even.xu@...el.com>
To: WangYuli <wangyuli@...ontech.com>, "Sun, Xinpeng" <xinpeng.sun@...el.com>,
	"jikos@...nel.org" <jikos@...nel.org>, "bentiss@...nel.org"
	<bentiss@...nel.org>
CC: "mpearson-lenovo@...ebb.ca" <mpearson-lenovo@...ebb.ca>,
	"srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
	"guanwentao@...ontech.com" <guanwentao@...ontech.com>, "phasta@...nel.org"
	<phasta@...nel.org>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "zhanjun@...ontech.com"
	<zhanjun@...ontech.com>, "niecheng1@...ontech.com" <niecheng1@...ontech.com>
Subject: RE: [PATCH] HID: intel-thc-hid: intel-quicki2c: pass correct
 arguments to acpi_evaluate_object



> -----Original Message-----
> From: WangYuli <wangyuli@...ontech.com>
> Sent: Thursday, April 17, 2025 9:50 PM
> To: Xu, Even <even.xu@...el.com>; Sun, Xinpeng <xinpeng.sun@...el.com>;
> jikos@...nel.org; bentiss@...nel.org
> Cc: mpearson-lenovo@...ebb.ca; srinivas.pandruvada@...ux.intel.com;
> guanwentao@...ontech.com; phasta@...nel.org; linux-input@...r.kernel.org;
> linux-kernel@...r.kernel.org; zhanjun@...ontech.com;
> niecheng1@...ontech.com; WangYuli <wangyuli@...ontech.com>
> Subject: [PATCH] HID: intel-thc-hid: intel-quicki2c: pass correct arguments to
> acpi_evaluate_object
> 
> From: Wentao Guan <guanwentao@...ontech.com>
> 
> Delete unused argument, pass correct argument to acpi_evaluate_object.
> 
> Log:
>   intel_quicki2c 0000:00:10.0: enabling device (0000 -> 0002)
>   ACPI: \_SB.PC00.THC0.ICRS: 1 arguments were passed to a non-method ACPI
> object (Buffer) (20230628/nsarguments-211)
>   ACPI: \_SB.PC00.THC0.ISUB: 1 arguments were passed to a non-method ACPI
> object (Buffer) (20230628/nsarguments-211)
> 
> Fixes: 5282e45ccbfa ("HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C ACPI
> interfaces")
> Signed-off-by: Wentao Guan <guanwentao@...ontech.com>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>  drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> index fa51155ebe39..8a8c4a46f927 100644
> --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> @@ -82,15 +82,10 @@ static int quicki2c_acpi_get_dsd_property(struct
> acpi_device *adev, acpi_string  {
>  	acpi_handle handle = acpi_device_handle(adev);
>  	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> -	union acpi_object obj = { .type = type };
> -	struct acpi_object_list arg_list = {
> -		.count = 1,
> -		.pointer = &obj,
> -	};
>  	union acpi_object *ret_obj;
>  	acpi_status status;
> 
> -	status = acpi_evaluate_object(handle, dsd_method_name, &arg_list,
> &buffer);
> +	status = acpi_evaluate_object(handle, dsd_method_name, NULL,
> &buffer);

Just tested this patch, it works.
Thanks for the fix!

Reviewed-by: Even Xu <even.xu@...el.com>

>  	if (ACPI_FAILURE(status)) {
>  		acpi_handle_err(handle,
>  				"Can't evaluate %s method: %d\n",
> dsd_method_name, status);
> --
> 2.49.0