linux-kernel - Re: [PATCH v3] mfd: core: Support auxiliary device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504182338.SwsgSLNm-lkp@intel.com>
Date: Fri, 18 Apr 2025 23:29:48 +0800
From: kernel test robot <lkp@...el.com>
To: Raag Jadav <raag.jadav@...el.com>, gregkh@...uxfoundation.org,
	david.m.ertman@...el.com, ira.weiny@...el.com, lee@...nel.org,
	andriy.shevchenko@...ux.intel.com, mika.westerberg@...ux.intel.com,
	heikki.krogerus@...ux.intel.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Raag Jadav <raag.jadav@...el.com>
Subject: Re: [PATCH v3] mfd: core: Support auxiliary device

Hi Raag,

kernel test robot noticed the following build warnings:

[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on lee-mfd/for-mfd-fixes linus/master v6.15-rc2 next-20250417]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/mfd-core-Support-auxiliary-device/20250418-203658
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link:    https://lore.kernel.org/r/20250418123433.2586383-1-raag.jadav%40intel.com
patch subject: [PATCH v3] mfd: core: Support auxiliary device
config: riscv-randconfig-001-20250418 (https://download.01.org/0day-ci/archive/20250418/202504182338.SwsgSLNm-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250418/202504182338.SwsgSLNm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504182338.SwsgSLNm-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mfd/mfd-core.c:389:31: warning: result of comparison of constant 2147483648 with expression of type 'int' is always false [-Wtautological-constant-out-of-range-compare]
     389 |         if (dev_is_pci(parent) && id == MFD_AUX_TYPE)
         |                                   ~~ ^  ~~~~~~~~~~~~
   1 warning generated.


vim +/int +389 drivers/mfd/mfd-core.c

   384	
   385	static int mfd_add_device(struct device *parent, int id, const struct mfd_cell *cells,
   386				  struct resource *mem_base, int irq_base, struct irq_domain *domain)
   387	{
   388		/* TODO: Convert the platform device abusers and remove this flag */
 > 389		if (dev_is_pci(parent) && id == MFD_AUX_TYPE)
   390			return mfd_add_auxiliary_device(parent, id, cells, mem_base, irq_base, domain);
   391	
   392		return mfd_add_platform_device(parent, id, cells, mem_base, irq_base, domain);
   393	}
   394	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki