linux-kernel - 回复: [PATCH] cgroup: Fix compilation issue due to cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93828629f46942b487ec2f6fd6dd373f@honor.com>
Date: Fri, 18 Apr 2025 02:03:43 +0000
From: gaoxu <gaoxu2@...or.com>
To: Kamalesh Babulal <kamalesh.babulal@...cle.com>, Tejun Heo <tj@...nel.org>,
	Johannes Weiner <hannes@...xchg.org>, Michal Koutný
	<mkoutny@...e.com>
CC: "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"surenb@...gle.com" <surenb@...gle.com>, yipengxiang <yipengxiang@...or.com>
Subject: 回复: [PATCH] cgroup: Fix compilation issue due to cgroup_mutex not being exported

> 
> On 4/17/25 1:00 PM, gaoxu wrote:
> [...]
> 
> > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index
> > 447ac857e..9e60ff629 100644
> > --- a/kernel/cgroup/cgroup.c
> > +++ b/kernel/cgroup/cgroup.c
> > @@ -90,7 +90,7 @@
> >  DEFINE_MUTEX(cgroup_mutex);
> >  DEFINE_SPINLOCK(css_set_lock);
> >
> > -#ifdef CONFIG_PROVE_RCU
> > +#if (defined CONFIG_PROVE_RCU || defined CONFIG_LOCKDEP)
> >  EXPORT_SYMBOL_GPL(cgroup_mutex);
> >  EXPORT_SYMBOL_GPL(css_set_lock);
> >  #endif
> 
> 
> It can be triggered when CONFIG_LOCK_STAT=y is enabled, which selects
> CONFIG_LOCKDEP=y and sets CONFIG_PROVE_RCU=n. The patch looks good to
> me.
> 
> You may also want to update the description above
> DEFINE_MUTEX(cgroup_mutex); to reflect the modifications introduced by this
> patch.
Received, thanks!
> 
> --
> Cheers,
> Kamalesh