linux-kernel - Re: [PATCH V2] LoongArch: Introduce the numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aANVMaepni3KeABI@kernel.org>
Date: Sat, 19 Apr 2025 10:48:01 +0300
From: Mike Rapoport <rppt@...nel.org>
To: Huacai Chen <chenhuacai@...ngson.cn>
Cc: Huacai Chen <chenhuacai@...nel.org>, loongarch@...ts.linux.dev,
	Xuefeng Li <lixuefeng@...ngson.cn>, Guo Ren <guoren@...nel.org>,
	Xuerui Wang <kernel@...0n.name>,
	Jiaxun Yang <jiaxun.yang@...goat.com>, linux-kernel@...r.kernel.org,
	Binbin Zhou <zhoubinbin@...ngson.cn>,
	Yuquan Wang <wangyuquan1236@...tium.com.cn>
Subject: Re: [PATCH V2] LoongArch: Introduce the numa_memblks conversion

Hi Huacai,

On Tue, Apr 15, 2025 at 03:21:18PM +0800, Huacai Chen wrote:
> Commit 87482708210ff3333a ("mm: introduce numa_memblks") has moved
> numa_memblks from x86 to the generic code, but LoongArch was left out
> of this conversion.
> 
> This patch introduces the generic numa_memblks for LoongArch.
> 
> In detail:
> 1. Enable NUMA_MEMBLKS (but disable NUMA_EMU) in Kconfig;
> 2. Use generic definition for numa_memblk and numa_meminfo;
> 3. Use generic implementation for numa_add_memblk() and its friends;
> 4. Use generic implementation for numa_set_distance() and its friends;
> 5. Use generic implementation for memory_add_physaddr_to_nid() and its
>    friends.
>
> Note: Disable NUMA_EMU because it needs more efforts and no obvious
> demand now.
> 
> Tested-by: Binbin Zhou <zhoubinbin@...ngson.cn>
> Signed-off-by: Yuquan Wang <wangyuquan1236@...tium.com.cn>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---
>  arch/loongarch/Kconfig                 |   1 +
>  arch/loongarch/include/asm/numa.h      |  14 ----
>  arch/loongarch/include/asm/sparsemem.h |   5 --
>  arch/loongarch/include/asm/topology.h  |   7 +-
>  arch/loongarch/kernel/acpi.c           |  11 ---
>  arch/loongarch/kernel/numa.c           | 108 +++----------------------
>  arch/loongarch/mm/init.c               |   8 --
>  mm/Kconfig                             |   1 +
>  8 files changed, 16 insertions(+), 139 deletions(-)

This is really cool simplification!

I wonder if maybe we can take a step or two further and make loongarch to
share more code with other architectures.

Is there a strong reason not to call numa_memblks_init() from
init_numa_memory()? 
And more broadly, maybe loongarch can be even switched to arch_numa?

-- 
Sincerely yours,
Mike.