linux-kernel - Re: [PATCH] platform/x86/amd/hsmp: change driver name from amd_hsmp to hsmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60715d85-48b4-4066-8a9a-c8d2b62ebb45@redhat.com>
Date: Sat, 19 Apr 2025 11:00:54 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Gregory Price <gourry@...rry.net>, platform-driver-x86@...r.kernel.org
Cc: naveenkrishna.chatradhi@....com, carlos.bilbao@...nel.org,
 ilpo.jarvinen@...ux.intel.com, suma.hegde@....com,
 linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH] platform/x86/amd/hsmp: change driver name from amd_hsmp
 to hsmp_acpi

Hi,

On 19-Apr-25 4:50 AM, Gregory Price wrote:
> The amd_hsmp and hsmp_acpi drivers fail to load together (whichever
> is loaded second, fails) because they have the same DRIVER_NAME.
> 
> Change hsmp_acpi DRIVER_NAME from amd_hsmp to hsmp_acpi.
> 
> Link: https://lore.kernel.org/all/20241021111428.2676884-8-suma.hegde@amd.com/
> Fixes: 7d3135d16356f ("platform/x86/amd/hsmp: Create separate ACPI, plat and common drivers")
> Signed-off-by: Gregory Price <gourry@...rry.net>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Note as mention in my reply to your other email, there do seem
to be some other potential issues with the pair of drivers which
need to be addressed. But this patch is good to have regardless.

Regards,

Hans




> ---
>  drivers/platform/x86/amd/hsmp/acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/amd/hsmp/acpi.c b/drivers/platform/x86/amd/hsmp/acpi.c
> index 444b43be35a2..a9c24502d3d2 100644
> --- a/drivers/platform/x86/amd/hsmp/acpi.c
> +++ b/drivers/platform/x86/amd/hsmp/acpi.c
> @@ -26,7 +26,7 @@
>  
>  #include "hsmp.h"
>  
> -#define DRIVER_NAME		"amd_hsmp"
> +#define DRIVER_NAME		"hsmp_acpi"
>  #define DRIVER_VERSION		"2.3"
>  #define ACPI_HSMP_DEVICE_HID	"AMDI0097"
>