linux-kernel - Re: [PATCH 0/2] riscv: dts: spacemit: Add clocks to pinctrl and UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aANwGZCIpMcd47IB@ketchup>
Date: Sat, 19 Apr 2025 09:42:49 +0000
From: Haylen Chu <heylenay@....org>
To: Yixun Lan <dlan@...too.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>
Cc: Alex Elder <elder@...cstar.com>, devicetree@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] riscv: dts: spacemit: Add clocks to pinctrl and UART

On Sat, Apr 19, 2025 at 11:32:29AM +0800, Yixun Lan wrote:
> Populate clock property for pinctrl and UART controller.
> 
> The pinctrl's clock dt-binding patch is still waiting to be merged[1].
> 
> The UART's dt-binding and driver code has already been accepted[2],
> so we now are only sending the DT part patch.
> 
> These two patches are abased on SpacemiT SoC tree's for-next branch[3]
> 
> Link: https://lore.kernel.org/r/20250416-02-k1-pinctrl-clk-v2-0-2b5fcbd4183c@gentoo.org [1]
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/log/?h=tty-next [2]
> Link: https://github.com/spacemit-com/linux/tree/for-next [3]
> Signed-off-by: Yixun Lan <dlan@...too.org>

Generally this looks good to me, but I realized that splitting the
commit that introduces clock controllers and the one that correctly
fills clock properties for various peripherals may cause bisectable
issues, i.e. the UART won't function with only the clock controller
introduced and no clk_ignore_unused specified on commandline.

If this isn't really a problem, for the whole series,

Reviewed-by: Haylen Chu <heylenay@....org>

> ---
> Yixun Lan (2):
>       riscv: dts: spacemit: Acquire clocks for pinctrl
>       riscv: dts: spacemit: Acquire clocks for UART
> 
>  arch/riscv/boot/dts/spacemit/k1.dtsi | 39 +++++++++++++++++++++++++++---------
>  1 file changed, 30 insertions(+), 9 deletions(-)
> ---
> base-commit: 279d51ad9f6dc0c667f6f141a669b2c921277d1a
> change-id: 20250419-05-dts-clock-026bfca75e5b
> 
> Best regards,
> -- 
> Yixun Lan
>