linux-kernel - [PATCH] drm/amd: Replace calls to kmalloc()+memcpy()+free(old) with krealloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <bgwysgwai2p4d564s5pod5xw2q27r6egqkkiycjt6v5xtwnpwi@jh5ogfr75rfi>
Date: Sat, 19 Apr 2025 15:40:09 +0300
From: "Nikola Z. Ivanov" <zlatistiv@...il.com>
To: alexander.deucher@....com, christian.koenig@....com
Cc: harry.wentland@....com, sunpeng.li@....com, siqueira@...lia.com, 
	airlied@...il.com, simona@...ll.ch, aurabindo.pillai@....com, marek.olsak@....com, 
	roman.li@....com, make24@...as.ac.cn, jfalempe@...hat.com, ivlipski@....com, 
	karthi.kandasamy@....com, amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: [PATCH] drm/amd: Replace calls to kmalloc()+memcpy()+free(old) with
 krealloc()

Possibly gets rid of some redundant calls to memcpy.

Signed-off-by: Nikola Z. Ivanov <zlatistiv@...il.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
index 56bc2644e492..7ffd0d8f9897 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
@@ -146,7 +146,7 @@ static void amdgpu_dm_plane_add_modifier(uint64_t **mods, uint64_t *size, uint64
 
 	if (*cap - *size < 1) {
 		uint64_t new_cap = *cap * 2;
-		uint64_t *new_mods = kmalloc(new_cap * sizeof(uint64_t), GFP_KERNEL);
+		uint64_t *new_mods = krealloc(*mods, new_cap * sizeof(uint64_t), GFP_KERNEL);
 
 		if (!new_mods) {
 			kfree(*mods);
@@ -154,8 +154,6 @@ static void amdgpu_dm_plane_add_modifier(uint64_t **mods, uint64_t *size, uint64
 			return;
 		}
 
-		memcpy(new_mods, *mods, sizeof(uint64_t) * *size);
-		kfree(*mods);
 		*mods = new_mods;
 		*cap = new_cap;
 	}
-- 
2.49.0