linux-kernel - Re: [PATCH v2] ipmi:si: Move SI type information into an info structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAO6DVh2knSoA20x@smile.fi.intel.com>
Date: Sat, 19 Apr 2025 17:58:21 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Corey Minyard <corey@...yard.net>
Cc: Linux Kernel <linux-kernel@...r.kernel.org>,
	OpenIPMI Developers <openipmi-developer@...ts.sourceforge.net>
Subject: Re: [PATCH v2] ipmi:si: Move SI type information into an info
 structure

On Thu, Apr 17, 2025 at 03:54:09PM -0500, Corey Minyard wrote:
> On Thu, Apr 17, 2025 at 06:58:21PM +0300, Andy Shevchenko wrote:
> > On Thu, Apr 17, 2025 at 06:55:35PM +0300, Andy Shevchenko wrote:
> > > On Wed, Apr 16, 2025 at 01:36:15PM -0500, Corey Minyard wrote:
> > > > Andy reported:
> > > > 
> > > > Debian clang version 19.1.7 is not happy when compiled with
> > > > `make W=1` (note, CONFIG_WERROR=y is the default):
> > > > 
> > > > ipmi_si_platform.c:268:15: error: cast to smaller integer type 'enum si_type'
> > > > +from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
> > 
> > It seems you copied'n'pasted from narrow screen. The lines should kept as is
> > (as long as they are) without an additional line break and plus sign.
> 
> Yep.  Thanks Andy.  Should this wait for for 6.16, or would 6.15 be
> better?

I prefer v6.15, but it's not that critical, and v6.16 would work. So, up to you.

> > > >   268 |         io.si_type      = (enum
> > > > +si_type)device_get_match_data(&pdev->dev);
> > 
> > Ditto.
> > 
> > > > The IPMI SI type is an enum that was cast into a pointer that was
> > > > then cast into an enum again.  That's not the greatest style, so
> > > > instead create an info structure to hold the data and use that.
> > > 
> > > Tested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko