linux-kernel - Re: [PATCH 2/2] logic_pio: Add detailed comments for find_io_range() and logic_pio_trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAO_hdYdKW1_Z-T8@smile.fi.intel.com>
Date: Sat, 19 Apr 2025 18:21:41 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: xiaopeitux@...mail.com
Cc: linux-kernel@...r.kernel.org, f.fangjian@...wei.com, robh@...nel.org,
	john.g.garry@...cle.com, xuwei5@...ilicon.com,
	Pei Xiao <xiaopei01@...inos.cn>
Subject: Re: [PATCH 2/2] logic_pio: Add detailed comments for find_io_range()
 and logic_pio_trans_cpuaddr()

On Fri, Apr 18, 2025 at 04:51:45PM +0800, xiaopeitux@...mail.com wrote:
> From: Pei Xiao <xiaopei01@...inos.cn>
> 
> Add comments that we were previously overlooked for find_io_range()
> and logic_pio_trans_cpuaddr().

You haven't run definitely the kernel-doc validator. There are missing Return
sections. And even style for returned value description differs in two...

Also, you have an issue with your tools, the cover letter is detached from the
patches. Please, take your time and fix that.

-- 
With Best Regards,
Andy Shevchenko