linux-kernel - Re: [PATCH v6 2/2] iio: adc: add support for Nuvoton NCT7201

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAO_8d7j-KgxbmKU@smile.fi.intel.com>
Date: Sat, 19 Apr 2025 18:23:29 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Eason Yang <j2anfernee@...il.com>, lars@...afoo.de, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, dlechner@...libre.com,
	nuno.sa@...log.com, javier.carrasco.cruz@...il.com,
	gstols@...libre.com, alisadariana@...il.com, tgamblin@...libre.com,
	olivier.moysan@...s.st.com, antoniu.miclaus@...log.com,
	eblanc@...libre.com, joao.goncalves@...adex.com,
	tobias.sperling@...ting.com, marcelo.schmitt@...log.com,
	angelogioacchino.delregno@...labora.com,
	thomas.bonnefille@...tlin.com, herve.codina@...tlin.com,
	chanh@...amperecomputing.com, KWLIU@...oton.com,
	yhyang2@...oton.com, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] iio: adc: add support for Nuvoton NCT7201

On Fri, Apr 18, 2025 at 05:13:26PM +0100, Jonathan Cameron wrote:
> On Wed, 16 Apr 2025 16:17:34 +0800
> Eason Yang <j2anfernee@...il.com> wrote:

...

> > +	struct device *dev = chip->dev;
> > +	__le16 data = cpu_to_le16(NCT7201_REG_CHANNEL_ENABLE_MASK);
> 
> Assign this value down near where it is used. That will generally help
> readability.

Actually it is a good, but not a main reason, the problem with this style is
long-term maintenance when some code may appear in between and become so long
that one can screw up this assignment at some point.

-- 
With Best Regards,
Andy Shevchenko