linux-kernel - Re: [PATCH] Input: sparcspkr - Avoid unannotated fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ac4jviwn7k7thbdgstnmz6ntjm7gjyafb322n32ukqnkl6uzp@mod6fkc5sicz>
Date: Fri, 18 Apr 2025 18:40:46 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: WangYuli <wangyuli@...ontech.com>
Cc: javier.carrasco.cruz@...il.com, wens@...e.org, 
	u.kleine-koenig@...libre.com, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
	davem@...s.ninka.net, zhanjun@...ontech.com, niecheng1@...ontech.com, 
	guanwentao@...ontech.com
Subject: Re: [PATCH] Input: sparcspkr - Avoid unannotated fall-through

On Tue, Apr 15, 2025 at 01:24:39PM +0800, WangYuli wrote:
> 1. Fix follow warnings with clang-21:
>   drivers/input/misc/sparcspkr.c:78:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>      78 |                 case SND_TONE: break;
>         |                 ^
>   drivers/input/misc/sparcspkr.c:78:3: note: insert 'break;' to avoid fall-through
>      78 |                 case SND_TONE: break;
>         |                 ^
>         |                 break;
>   drivers/input/misc/sparcspkr.c:113:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>     113 |                 case SND_TONE: break;
>         |                 ^
>   drivers/input/misc/sparcspkr.c:113:3: note: insert 'break;' to avoid fall-through
>     113 |                 case SND_TONE: break;
>         |                 ^
>         |                 break;
>   2 warnings generated.
> 2. Reformat this code block to enhance readability.
> 
> Fixes: 215ea853a9 ("[INPUT]: Add EBUS/ISA speaker input driver for Sparc.")  #In history tree

Thank you for the patch. There is actually no bug, so I dropped the
"Fixes" tag, but otherwise everything looks good and I applied it.

Thanks.

-- 
Dmitry