linux-kernel - Re: [PATCH] fs:gfs:glock: Delete the invalid pointer insert_pt in add_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHc6FU7rJ4uh5mL-LGNUT1EtTK8BKmrh+S+Gq-dqwVjoviQWxA@mail.gmail.com>
Date: Sat, 19 Apr 2025 21:03:38 +0200
From: Andreas Gruenbacher <agruenba@...hat.com>
To: Chaohai Chen <wdhh6@...yun.com>
Cc: gfs2@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs:gfs:glock: Delete the invalid pointer insert_pt in add_to_queue()

Hello,

On Sat, Apr 19, 2025 at 8:54 AM Chaohai Chen <wdhh6@...yun.com> wrote:
> The point insert_pt is always NULL, no one will change it, delete the code
> and useless logic about it.

the code in question has already been removed in commit 0360faca5d4d
("gfs2: Remove more dead code in add_to_queue").

Please always check the for-next branch of
git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git
before sending patches. In this case though, the fix has even been
merged into mainline already.

Thanks,
Andreas