linux-kernel - Re: [PATCH] crypto: lib/chacha - restore ability to remove modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAMWyCjoFZJf9tOQ@gondor.apana.org.au>
Date: Sat, 19 Apr 2025 11:21:44 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: lib/chacha - restore ability to remove modules

Eric Biggers <ebiggers@...nel.org> wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Though the module_exit functions are now no-ops, they should still be
> defined, since otherwise the modules become unremovable.
> 
> Fixes: 08820553f33a ("crypto: arm/chacha - remove the redundant skcipher algorithms")
> Fixes: 8c28abede16c ("crypto: arm64/chacha - remove the skcipher algorithms")
> Fixes: f7915484c020 ("crypto: powerpc/chacha - remove the skcipher algorithms")
> Fixes: ceba0eda8313 ("crypto: riscv/chacha - implement library instead of skcipher")
> Fixes: 632ab0978f08 ("crypto: x86/chacha - remove the skcipher algorithms")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
> arch/arm/crypto/chacha-glue.c           | 5 +++++
> arch/arm64/crypto/chacha-neon-glue.c    | 5 +++++
> arch/powerpc/crypto/chacha-p10-glue.c   | 5 +++++
> arch/riscv/crypto/chacha-riscv64-glue.c | 5 +++++
> arch/x86/crypto/chacha_glue.c           | 5 +++++
> 5 files changed, 25 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt