linux-kernel - Re: [PATCH v2 2/2] vmscan,cgroup: apply mems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAMbT0Qh6yyrSJqt@gourry-fedora-PF4VCD3F>
Date: Fri, 18 Apr 2025 23:41:03 -0400
From: Gregory Price <gourry@...rry.net>
To: Tejun Heo <tj@...nel.org>
Cc: cgroups@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, kernel-team@...a.com,
	hannes@...xchg.org, mkoutny@...e.com, longman@...hat.com,
	mhocko@...nel.org, roman.gushchin@...ux.dev, shakeel.butt@...ux.dev,
	muchun.song@...ux.dev, akpm@...ux-foundation.org
Subject: Re: [PATCH v2 2/2] vmscan,cgroup: apply mems_effective to reclaim

On Fri, Apr 18, 2025 at 11:27:55PM -0400, Gregory Price wrote:
> On Fri, Apr 18, 2025 at 05:06:20PM -1000, Tejun Heo wrote:
> > Hello,
> > 
> > On Thu, Apr 17, 2025 at 11:13:52PM -0400, Gregory Price wrote:
> > ...
> > > +static inline bool mem_cgroup_node_allowed(struct mem_cgroup *memcg, int nid)
> > > +{
> > > +	return memcg ? cgroup_node_allowed(memcg->css.cgroup, nid) : true;
> > > +}
> > > +
> > ...
> > > +bool cgroup_node_allowed(struct cgroup *cgroup, int nid)
> > > +{
> > > +	return cpuset_node_allowed(cgroup, nid);
> > > +}
> > ...
> > > +bool cpuset_node_allowed(struct cgroup *cgroup, int nid)
> > > +{
> > 
> > What does the indirection through cgroup_node_allowed() add? Why not just
> > call cpuset directly?
> > 
> 
> This is an artifact of me trying to figure out how to get this to build
> with allconfig (matrix of CPUSET and MEM_CGROUP).
> 
... snip ...

Looking back through the include graph again

The reason was lack of inclusion of cpuset.h in memcontrol.c while
chasing the allconfig solution.

I was trying to following the current includes rather than making the
graph more complex - it wasn't clear to me whether going directly to
cpuset.h from memcontrol.c made sense - since memcontrol can be built
without cpuset.

The graph here is a head scratcher.  I'll still try a build with
cpuset.h included in memcontrol.c.

~Gregory