linux-kernel - Re: [PATCH 2/2] media: atomisp: Remove unused atomisp_compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VePHnr7fVnO43Vhc59_CQKQ1TfaAxzj3dd_t0nqvzFRdA@mail.gmail.com>
Date: Sat, 19 Apr 2025 07:58:55 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
Cc: andy@...nel.org, sakari.ailus@...ux.intel.com, 
	Hans de Goede <hdegoede@...hat.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, 
	linux-media@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 2/2] media: atomisp: Remove unused atomisp_compat_ioctl32()
 declaration

On Fri, Apr 18, 2025 at 10:19 AM Hardevsinh Palaniya
<hardevsinh.palaniya@...iconsignals.io> wrote:
>
> Since its definition was deleted in a previous patch[1]

This is odd. Previous patch from you? The Link is to Arnd's one, which
is quite too old to be "previous patch".

> and there are no remaining users of this function in
> the codebase.

> Link[1]:https://lore.kernel.org/linux-media/20210614103409.3154127-7-arnd@kernel.org/
>
> Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>

Same comment as per previous patch.

> ---

Overall I don't know why it's a separate patch and can't be squashed
with the first one. Whatever, it's staging and it's fine that we get
rid of dead code.

-- 
With Best Regards,
Andy Shevchenko