linux-kernel - Re: [PATCH v5] hwmon: (max77705) add initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3bc76874-2942-4454-b785-896772bdad6d@roeck-us.net>
Date: Sun, 20 Apr 2025 09:06:48 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Dzmitry Sankouski <dsankouski@...il.com>, Jean Delvare
 <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
 Chanwoo Choi <cw00.choi@...sung.com>, Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] hwmon: (max77705) add initial support

On 4/19/25 12:03, Dzmitry Sankouski wrote:
> Add support for max77705 hwmon. Includes charger input, system bus, and
> vbyp measurements.
> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> ---
> Maxim MAX77705 is a Companion Power Management and Type-C interface IC.
> It includes charger and fuel gauge blocks, and is capable of measuring
> charger input current, system bus volatage and current, and bypass
> voltage.
> 
> Add support for mentioned measurements.
> ---
> Changes in v5:
> - fix compile warning
> - review fixes
> - Link to v4: https://lore.kernel.org/r/20250412-initial-support-for-max77705-sensors-v4-1-2e4cf268a3d0@gmail.com
> 
> Changes in v4:
> - Fix review comments.
> - Link to v3: https://lore.kernel.org/r/20250405-initial-support-for-max77705-sensors-v3-1-e5f64fccd005@gmail.com
> 
> Changes in v3:
> - Fix review comments.
> - Fix v2 changed message.
> - Link to v2: https://lore.kernel.org/r/20250304-initial-support-for-max77705-sensors-v2-1-58d2207c732b@gmail.com
> 
> Changes in v2:
> - Fix review comments.
> - Link to v1: https://lore.kernel.org/r/20250225-initial-support-for-max77705-sensors-v1-1-2be6467628b0@gmail.com
> ---
> Changes in v5:
> - remove now unneeded max77705_hwmon_readable_table
> - remove channel num check in max77705_is_visible, since there's only 2
>    channels
> - make is_signed bool
> - remove is_signed: pass is_signed as true/false
> 
...
> +static const struct regmap_range max77705_hwmon_readable_ranges[] = {

As 0-day (and builds with W=1) points out, this is now also unused.

Guenter