linux-kernel - Re: [PATCH 1/3] ARM: dts: qcom: msm8974-oneplus-bacon: Add alias for mmc0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <k7dm2tpw3mg34fydyug3rjnkwgfu2lwwzddd4edmano6jsgoiv@6klzba5rjpdy>
Date: Sun, 20 Apr 2025 12:05:36 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Luca Weiss <luca@...aweiss.eu>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: qcom: msm8974-oneplus-bacon: Add alias for
 mmc0

On Sat, Apr 19, 2025 at 11:03:57AM +0200, Luca Weiss wrote:
> Add an alias for the internal storage so it always becomes mmcblk0.
> 

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
calls for a problem description to start your commit message. Sometimes
the problem is obvious, but here &sdhc_2 is disable on this board, so
when does this not become mmcblk0? What is the problem you're solving?

Regards,
Bjorn

> Signed-off-by: Luca Weiss <luca@...aweiss.eu>
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> index 4c8edadea0ac63db668dbd666fbb8d92e23232b7..88ff6535477bffefe475cc5fe927b3cc5d223084 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> @@ -13,6 +13,7 @@ / {
>  	qcom,board-id = <8 0>;
>  
>  	aliases {
> +		mmc0 = &sdhc_1;
>  		serial0 = &blsp1_uart2;
>  	};
>  
> 
> -- 
> 2.49.0
>