linux-kernel - Re: [PATCH v3] staging: iio: ad5933: Correct settling cycles encoding per datasheet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKUZ0z+aBu-cLKqbU6nHjSPDWzdF08z484p+s0tqMM1c1rTwXA@mail.gmail.com>
Date: Sat, 19 Apr 2025 21:22:50 -0400
From: Gabriel Shahrouzi <gshahrouzi@...il.com>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: gregkh@...uxfoundation.org, jic23@...nel.org, lars@...afoo.de, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-staging@...ts.linux.dev, Michael.Hennerich@...log.com, 
	skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev, 
	stable@...r.kernel.org
Subject: Re: [PATCH v3] staging: iio: ad5933: Correct settling cycles encoding
 per datasheet

On Sat, Apr 19, 2025 at 8:52 PM Marcelo Schmitt
<marcelo.schmitt1@...il.com> wrote:
>
> On 04/19, Gabriel Shahrouzi wrote:
> > Implement the settling cycles encoding as specified in the AD5933
> > datasheet, Table 13 ("Number of Settling Times Cycles Register"). The
> > previous logic did not correctly translate the user-requested effective
> > cycle count into the required 9-bit base + 2-bit multiplier format
> > (D10..D0) for values exceeding 511.
> Hmm, the above description should probably go on the refactoring patch I think.
> Otherwise looks good.
You're right - will update that for v4. I don't think my description
was accurate either since the old logic did correctly map the cycle
counts to the correct bits. It just didn't use the correct mask.
>
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
>
> >
> > Clamp the user input for out_altvoltage0_settling_cycles to the
> > maximum effective value of 2044 cycles (511 * 4x multiplier).
> >
> > Fixes: f94aa354d676 ("iio: impedance-analyzer: New driver for AD5933/4 Impedance Converter, Network Analyzer")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@...il.com>
> > ---
> > Changes in v3:
> >       - Only include fix (remove refactoring which will be its own
> >         separate patch).
> > Changes in v2:
> >         - Fix spacing in comment around '+'.
> >         - Define mask and values for settling cycle multipliers.
> > ---