linux-kernel - [PATCH] kvm: Improve help message clarity in dirty_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250420192505.157018-1-tinuk11c@gmail.com>
Date: Mon, 21 Apr 2025 00:55:05 +0530
From: Tinu K Cheriya <tinuk11c@...il.com>
To: linux-kernel@...r.kernel.org
Cc: tinukcheriya <tinuk11c@...il.com>
Subject: [PATCH] kvm: Improve help message clarity in dirty_log_test

From: tinukcheriya <tinuk11c@...il.com>

Signed-off-by: tinukcheriya <tinuk11c@...il.com>
---
 tools/testing/selftests/kvm/dirty_log_test.c | 30 +++++++++++---------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c
index 54da9cc20db4..ac01cf198469 100644
--- a/tools/testing/selftests/kvm/dirty_log_test.c
+++ b/tools/testing/selftests/kvm/dirty_log_test.c
@@ -503,22 +503,24 @@ static void help(char *name)
 	int i;
 
 	puts("");
-	printf("usage: %s [-h] [-i iterations] [-I interval] "
-	       "[-p offset] [-m mode]\n", name);
+	printf("Usage: %s [-h] [-i iterations] [-I interval] [-p offset] [-m mode]\n", name);
 	puts("");
-	printf(" -i: specify iteration counts (default: %"PRIu64")\n",
-	       TEST_HOST_LOOP_N);
-	printf(" -I: specify interval in ms (default: %"PRIu64" ms)\n",
-	       TEST_HOST_LOOP_INTERVAL);
-	printf(" -p: specify guest physical test memory offset\n"
-	       "     Warning: a low offset can conflict with the loaded test code.\n");
-	printf(" -M: specify the host logging mode "
-	       "(default: run all log modes).  Supported modes: \n\t");
+	printf(" -i: Specify the number of test iterations (default: %"PRIu64")\n", 			TEST_HOST_LOOP_N);
+
+	printf(" -p: Specify the guest physical memory offset for the test.\n"
+       "     Warning: Low offsets may conflict with test code loaded in memory.\n");
+	printf(" -p: Specify the guest physical memory offset for the test.\n"
+       "     Warning: Low offsets may conflict with test code loaded in memory.\n");
+
+	printf(" -M: Specify the host logging mode (default: run all log modes).\n"
+       "     Supported modes:\n\t");
+
 	log_modes_dump();
-	printf(" -m: specify the guest mode ID to test "
-	       "(default: test all supported modes)\n"
-	       "     This option may be used multiple times.\n"
-	       "     Guest mode IDs:\n");
+	printf(" -m: Specify the guest mode ID to test "
+       "(default: test all supported modes).\n"
+       "     You may use this option multiple times.\n"
+       "     Guest mode IDs:\n");
+
 	for (i = 0; i < NUM_VM_MODES; ++i) {
 		printf("         %d:    %s%s\n", i, vm_guest_mode_string(i),
 		       guest_modes[i].supported ? " (supported)" : "");
-- 
2.25.1