linux-kernel - Re: [PATCH v3 2/2] vmscan,cgroup: apply mems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAWKSGsWHipFfi1l@gourry-fedora-PF4VCD3F>
Date: Sun, 20 Apr 2025 19:59:04 -0400
From: Gregory Price <gourry@...rry.net>
To: Waiman Long <llong@...hat.com>
Cc: linux-mm@...ck.org, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...a.com,
	hannes@...xchg.org, mhocko@...nel.org, roman.gushchin@...ux.dev,
	shakeel.butt@...ux.dev, muchun.song@...ux.dev, tj@...nel.org,
	mkoutny@...e.com, akpm@...ux-foundation.org
Subject: Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim

On Sat, Apr 19, 2025 at 08:31:41PM -0400, Waiman Long wrote:
> On 4/19/25 1:38 AM, Gregory Price wrote:
> > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> > index 893a4c340d48..c64b4a174456 100644
> > --- a/include/linux/cpuset.h
> > +++ b/include/linux/cpuset.h
> > @@ -171,6 +171,7 @@ static inline void set_mems_allowed(nodemask_t nodemask)
> >   	task_unlock(current);
> >   }
> > +extern bool cpuset_node_allowed(struct cgroup *cgroup, int nid);
> >   #else /* !CONFIG_CPUSETS */
> >   static inline bool cpusets_enabled(void) { return false; }
> > @@ -282,6 +283,10 @@ static inline bool read_mems_allowed_retry(unsigned int seq)
> >   	return false;
> >   }
> > +static inline bool cpuset_node_allowed(struct cgroup *cgroup, int nid)
> > +{
> > +	return false;
> > +}
> >   #endif /* !CONFIG_CPUSETS */
> 
> I suppose we should return true in the !CONFIG_CPUSETS case.
> 
> Other than that, the patch looks good to me.
> 

Woop, quite right, thanks.

I'll v4 and hopefully get some -mm feedback

~Gregory