linux-kernel - Re: [PATCH] mm, slab: clean up slab->obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b517fe3-635c-6785-886b-6ad38f4de11a@google.com>
Date: Sat, 19 Apr 2025 19:46:54 -0700 (PDT)
From: David Rientjes <rientjes@...gle.com>
To: Zhenhua Huang <quic_zhenhuah@...cinc.com>
cc: cl@...ux.com, vbabka@...e.cz, roman.gushchin@...ux.dev, 
    harry.yoo@...cle.com, surenb@...gle.com, pasha.tatashin@...een.com, 
    akpm@...ux-foundation.org, linux-mm@...ck.org, 
    linux-kernel@...r.kernel.org, quic_tingweiz@...cinc.com
Subject: Re: [PATCH] mm, slab: clean up slab->obj_exts always

On Fri, 18 Apr 2025, Zhenhua Huang wrote:

> When memory allocation profiling is disabled at runtime or due to an
> error, shutdown_mem_profiling() is called: slab->obj_exts which
> previously allocated remains.
> It won't be cleared by unaccount_slab() because of
> mem_alloc_profiling_enabled() not true. It's incorrect, slab->obj_exts
> should always be cleaned up in unaccount_slab() to avoid following error:
> 
> [...]BUG: Bad page state in process...
> ..
> [...]page dumped because: page still charged to cgroup
> 
> Fixes: 21c690a349baa ("mm: introduce slabobj_ext to support slab object extensions")
> Signed-off-by: Zhenhua Huang <quic_zhenhuah@...cinc.com>

Acked-by: David Rientjes <rientjes@...gle.com>