linux-kernel - Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aASWjGNpn1QZYgZb@gondor.apana.org.au>
Date: Sun, 20 Apr 2025 14:39:08 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: "Gupta, Nipun" <nipun.gupta@....com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, davem@...emloft.net,
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, krzk+dt@...nel.org,
	gregkh@...uxfoundation.org, robh@...nel.org, conor+dt@...nel.org,
	ogabbay@...nel.org, maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com,
	simona@...ll.ch, derek.kiernan@....com, dragan.cvetic@....com,
	arnd@...db.de, praveen.jain@....com, harpreet.anand@....com,
	nikhil.agarwal@....com, srivatsa@...il.mit.edu, code@...icks.com,
	ptsm@...ux.microsoft.com, linux-crypto@...r.kernel.org,
	David Howells <dhowells@...hat.com>, Lukas Wunner <lukas@...ner.de>,
	Ignat Korchagin <ignat@...udflare.com>, keyrings@...r.kernel.org,
	Stephan Müller <smueller@...onox.de>
Subject: Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

On Thu, Apr 17, 2025 at 09:02:15PM +0530, Gupta, Nipun wrote:
>
> Thanks for pointing out to the C file, but as these these system calls can
> support only synchronous operations, precludes their use for asynchronous
> operations. In the TLS handshakes, where multiple connections occur
> simultaneously, asynchronous operations are beneficial. OpenSSL ASYNC
> support can very well utilizes the asynchronous operations while
> establishing multiple TLS connections.

In that case we should extend af_alg to support akcipher algorithms.

Having every crypto driver make up its own user-space PKI interface
is not scalable.

I held back on adding akcipher to af_alg because it would lead to
the freezing of our akcipher API.  But it's time to do this.

Being the first user of such an interface, could you please post
your OpenSSL patches as well so that we can look at what's actually
needed?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt