linux-kernel - Re: [PATCH v2 1/2] arm64: patching: Rename aarch64_insn_copy to text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADBMgpwh+9YxbGvyWwT3VjFLaAvdFFexHe-9yBmpOYsPsN-xrg@mail.gmail.com>
Date: Mon, 21 Apr 2025 15:14:21 -0700
From: Dylan Hatch <dylanbhatch@...gle.com>
To: Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, Puranjay Mohan <puranjay@...nel.org>, 
	Xu Kuohai <xukuohai@...weicloud.com>, Philippe Mathieu-Daudé <philmd@...aro.org>, 
	Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, 
	"Mike Rapoport (Microsoft)" <rppt@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
	Geert Uytterhoeven <geert@...ux-m68k.org>, Luis Chamberlain <mcgrof@...nel.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, Song Liu <song@...nel.org>, 
	Ard Biesheuvel <ardb@...nel.org>, Mark Rutland <mark.rutland@....com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Roman Gushchin <roman.gushchin@...ux.dev>
Subject: Re: [PATCH v2 1/2] arm64: patching: Rename aarch64_insn_copy to text_poke.

On Fri, Apr 11, 2025 at 6:10 PM Dylan Hatch <dylanbhatch@...gle.com> wrote:
>
> Match the name and signature of the equivalent in the x86 text-poke API.
> Making the src pointer const also allows this function to be
> interchangeable with memcpy().
>
> Signed-off-by: Dylan Hatch <dylanbhatch@...gle.com>
> ---
>  arch/arm64/include/asm/text-patching.h |  2 +-
>  arch/arm64/kernel/patching.c           | 12 ++++++------
>  arch/arm64/net/bpf_jit_comp.c          |  2 +-
>  3 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/include/asm/text-patching.h b/arch/arm64/include/asm/text-patching.h
> index 587bdb91ab7a6..450d806d11109 100644
> --- a/arch/arm64/include/asm/text-patching.h
> +++ b/arch/arm64/include/asm/text-patching.h
> @@ -9,7 +9,7 @@ int aarch64_insn_write(void *addr, u32 insn);
>
>  int aarch64_insn_write_literal_u64(void *addr, u64 val);
>  void *aarch64_insn_set(void *dst, u32 insn, size_t len);
> -void *aarch64_insn_copy(void *dst, void *src, size_t len);
> +void *text_poke(void *dst, const void *src, size_t len);
>
>  int aarch64_insn_patch_text_nosync(void *addr, u32 insn);
>  int aarch64_insn_patch_text(void *addrs[], u32 insns[], int cnt);
> diff --git a/arch/arm64/kernel/patching.c b/arch/arm64/kernel/patching.c
> index 1041bc67a3eee..e07dc32620053 100644
> --- a/arch/arm64/kernel/patching.c
> +++ b/arch/arm64/kernel/patching.c
> @@ -102,9 +102,9 @@ noinstr int aarch64_insn_write_literal_u64(void *addr, u64 val)
>         return ret;
>  }
>
> -typedef void text_poke_f(void *dst, void *src, size_t patched, size_t len);
> +typedef void text_poke_f(void *dst, const void *src, size_t patched, size_t len);
>
> -static void *__text_poke(text_poke_f func, void *addr, void *src, size_t len)
> +static void *__text_poke(text_poke_f func, void *addr, const void *src, size_t len)
>  {
>         unsigned long flags;
>         size_t patched = 0;
> @@ -132,12 +132,12 @@ static void *__text_poke(text_poke_f func, void *addr, void *src, size_t len)
>         return addr;
>  }
>
> -static void text_poke_memcpy(void *dst, void *src, size_t patched, size_t len)
> +static void text_poke_memcpy(void *dst, const void *src, size_t patched, size_t len)
>  {
>         copy_to_kernel_nofault(dst, src + patched, len);
>  }
>
> -static void text_poke_memset(void *dst, void *src, size_t patched, size_t len)
> +static void text_poke_memset(void *dst, const void *src, size_t patched, size_t len)
>  {
>         u32 c = *(u32 *)src;
>
> @@ -145,14 +145,14 @@ static void text_poke_memset(void *dst, void *src, size_t patched, size_t len)
>  }
>
>  /**
> - * aarch64_insn_copy - Copy instructions into (an unused part of) RX memory
> + * text_poke - Copy instructions into (an unused part of) RX memory
>   * @dst: address to modify
>   * @src: source of the copy
>   * @len: length to copy
>   *
>   * Useful for JITs to dump new code blocks into unused regions of RX memory.
>   */
> -noinstr void *aarch64_insn_copy(void *dst, void *src, size_t len)
> +noinstr void *text_poke(void *dst, const void *src, size_t len)
>  {
>         /* A64 instructions must be word aligned */
>         if ((uintptr_t)dst & 0x3)
> diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
> index 70d7c89d3ac90..b5be90edff410 100644
> --- a/arch/arm64/net/bpf_jit_comp.c
> +++ b/arch/arm64/net/bpf_jit_comp.c
> @@ -2047,7 +2047,7 @@ bool bpf_jit_supports_kfunc_call(void)
>
>  void *bpf_arch_text_copy(void *dst, void *src, size_t len)
>  {
> -       if (!aarch64_insn_copy(dst, src, len))
> +       if (!text_poke(dst, src, len))
>                 return ERR_PTR(-EINVAL);
>         return dst;
>  }
> --
> 2.49.0.604.gff1f9ca942-goog
>

Friendly ping.