linux-kernel - drivers/iio/adc/ad7173.c:915:8: error: implicit declaration of function 'ad7173_calibrate_all'; did you mean 'ad_sd_calibrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202504220605.Y55UtCP1-lkp@intel.com>
Date: Tue, 22 Apr 2025 06:54:55 +0800
From: kernel test robot <lkp@...el.com>
To: Guillaume Ranquet <granquet@...libre.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: drivers/iio/adc/ad7173.c:915:8: error: implicit declaration of
 function 'ad7173_calibrate_all'; did you mean 'ad_sd_calibrate_all'?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9d7a0577c9db35c4cc52db90bc415ea248446472
commit: 031bdc8aee01b7b298159eee541844d8bff4467d iio: adc: ad7173: add calibration support
date:   4 months ago
config: sh-randconfig-r051-20250422 (https://download.01.org/0day-ci/archive/20250422/202504220605.Y55UtCP1-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250422/202504220605.Y55UtCP1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504220605.Y55UtCP1-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/iio/adc/ad7173.c: In function 'ad7173_setup':
>> drivers/iio/adc/ad7173.c:915:8: error: implicit declaration of function 'ad7173_calibrate_all'; did you mean 'ad_sd_calibrate_all'? [-Werror=implicit-function-declaration]
     ret = ad7173_calibrate_all(st, indio_dev);
           ^~~~~~~~~~~~~~~~~~~~
           ad_sd_calibrate_all
   drivers/iio/adc/ad7173.c: At top level:
>> drivers/iio/adc/ad7173.c:1141:14: error: 'ad7173_calibsys_ext_info' undeclared here (not in a function); did you mean 'ad7173_sigma_delta_info'?
     .ext_info = ad7173_calibsys_ext_info,
                 ^~~~~~~~~~~~~~~~~~~~~~~~
                 ad7173_sigma_delta_info
   cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
   Depends on [n]: GPIOLIB [=n] || NEW_LEDS [=y] && GPIOLIB [=n]
   Selected by [m]:
   - BACKLIGHT_KTD2801 [=m] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=m]


vim +915 drivers/iio/adc/ad7173.c

   879	
   880	static int ad7173_setup(struct iio_dev *indio_dev)
   881	{
   882		struct ad7173_state *st = iio_priv(indio_dev);
   883		struct device *dev = &st->sd.spi->dev;
   884		u8 buf[AD7173_RESET_LENGTH];
   885		unsigned int id;
   886		int ret;
   887	
   888		/* reset the serial interface */
   889		memset(buf, 0xff, AD7173_RESET_LENGTH);
   890		ret = spi_write_then_read(st->sd.spi, buf, sizeof(buf), NULL, 0);
   891		if (ret < 0)
   892			return ret;
   893	
   894		/* datasheet recommends a delay of at least 500us after reset */
   895		fsleep(500);
   896	
   897		ret = ad_sd_read_reg(&st->sd, AD7173_REG_ID, 2, &id);
   898		if (ret)
   899			return ret;
   900	
   901		id &= AD7173_ID_MASK;
   902		if (id != st->info->id)
   903			dev_warn(dev, "Unexpected device id: 0x%04X, expected: 0x%04X\n",
   904				 id, st->info->id);
   905	
   906		st->adc_mode |= AD7173_ADC_MODE_SING_CYC;
   907		st->interface_mode = 0x0;
   908	
   909		st->config_usage_counter = 0;
   910		st->config_cnts = devm_kcalloc(dev, st->info->num_configs,
   911					       sizeof(*st->config_cnts), GFP_KERNEL);
   912		if (!st->config_cnts)
   913			return -ENOMEM;
   914	
 > 915		ret = ad7173_calibrate_all(st, indio_dev);
   916		if (ret)
   917			return ret;
   918	
   919		/* All channels are enabled by default after a reset */
   920		return ad7173_disable_all(&st->sd);
   921	}
   922	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki