linux-kernel - Re: [PATCH v3 2/2] vmscan,cgroup: apply mems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <snxed24sts5vsrcgi3aajxgngaswe2dtzf4kacfq7nyzc4aayt@4fmqp7i4gs3b>
Date: Mon, 21 Apr 2025 16:37:20 -0700
From: Shakeel Butt <shakeel.butt@...ux.dev>
To: Gregory Price <gourry@...rry.net>
Cc: linux-mm@...ck.org, cgroups@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-team@...a.com, longman@...hat.com, hannes@...xchg.org, 
	mhocko@...nel.org, roman.gushchin@...ux.dev, muchun.song@...ux.dev, tj@...nel.org, 
	mkoutny@...e.com, akpm@...ux-foundation.org
Subject: Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim

On Sat, Apr 19, 2025 at 01:38:24AM -0400, Gregory Price wrote:
>  static unsigned int shrink_folio_list(struct list_head *folio_list,
>  		struct pglist_data *pgdat, struct scan_control *sc,
> -		struct reclaim_stat *stat, bool ignore_references)
> +		struct reclaim_stat *stat, bool ignore_references,
> +		struct mem_cgroup *memcg)
>  {
>  	struct folio_batch free_folios;
>  	LIST_HEAD(ret_folios);
> @@ -1109,7 +1116,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
>  	folio_batch_init(&free_folios);
>  	memset(stat, 0, sizeof(*stat));
>  	cond_resched();
> -	do_demote_pass = can_demote(pgdat->node_id, sc);
> +	do_demote_pass = can_demote(pgdat->node_id, sc, memcg);

For code paths where we might have folios of different memcgs in
folio_list, should we look at individual folios for their memcgs or is
it ok to ignore such cases? If we are ignoring then let's add a comment
about that.