linux-kernel - Re: [PATCH v7 11/14] xfs: add xfs_file_dio_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2467484b-382b-47c2-ae70-4a41d63cf4fc@oracle.com>
Date: Mon, 21 Apr 2025 06:47:44 +0100
From: John Garry <john.g.garry@...cle.com>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: brauner@...nel.org, hch@....de, viro@...iv.linux.org.uk, jack@...e.cz,
        cem@...nel.org, linux-fsdevel@...r.kernel.org, dchinner@...hat.com,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        ojaswin@...ux.ibm.com, ritesh.list@...il.com,
        martin.petersen@...cle.com, linux-ext4@...r.kernel.org,
        linux-block@...r.kernel.org, catherine.hoang@...cle.com,
        linux-api@...r.kernel.org
Subject: Re: [PATCH v7 11/14] xfs: add xfs_file_dio_write_atomic()

On 21/04/2025 05:00, Darrick J. Wong wrote:
>> @@ -843,6 +909,8 @@ xfs_file_dio_write(
>>   		return xfs_file_dio_write_unaligned(ip, iocb, from);
>>   	if (xfs_is_zoned_inode(ip))
>>   		return xfs_file_dio_write_zoned(ip, iocb, from);
> What happens to an IOCB_ATOMIC write to a zoned file?  I think the
> ioend for an atomic write to a zoned file involves a similar change as
> an outofplace atomic write to a file (one big transaction to absorb
> all the mapping changes) but I don't think the zoned code quite does
> that...?

Correct. For now, I don't think that we should try to support zoned 
device atomic writes. However we don't have proper checks for this. How 
about adding a xfs_has_zoned() check in xfs_get_atomic_write_{min, max, 
opt}()?

Thanks,
John