linux-kernel - Re: [PATCH] xfs: add tunable threshold parameter for triggering zone GC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250421083128.GA20490@lst.de>
Date: Mon, 21 Apr 2025 10:31:28 +0200
From: hch <hch@....de>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Carlos Maiolino <cem@...nel.org>, Hans Holmberg <Hans.Holmberg@....com>,
	Dave Chinner <david@...morbit.com>,
	"Darrick J . Wong" <djwong@...nel.org>, hch <hch@....de>,
	"linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xfs: add tunable threshold parameter for triggering
 zone GC

On Sun, Apr 20, 2025 at 10:42:56AM -0700, Guenter Roeck wrote:
> A possible local solution is below. Note the variable type change from s64 to u64.

I think that'll need a lower bound of 0 thrown in to be safe as these
counters can occasionally underflow.

Otherwise this is probably the right thing to do for now until mult_frac
gets fixed eventually.  Can you add a comment why this open codes
mult_frac to the code and send a formal patch for it?