linux-kernel - Re: [PATCH] crypto: using size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f9b16a3-f3ba-4ccf-bf49-a84c5419d5d2@wanadoo.fr>
Date: Mon, 21 Apr 2025 10:32:28 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Su Hui <suhui@...china.com>, davem@...emloft.net,
 herbert@...dor.apana.org.au
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] crypto: using size_add() for kmalloc()

Le 21/04/2025 à 09:43, Su Hui a écrit :
> On 2025/4/21 15:10, Christophe JAILLET wrote:
>> Le 21/04/2025 à 07:51, Su Hui a écrit :
>>> It's safer to use size_add() to replace open-coded aithmetic in 
>>> allocator
>>> arguments, because size_add() can prevent possible overflow problem.
>>>
>>> Signed-off-by: Su Hui <suhui@...china.com>
>>> ---
>>>   include/crypto/aead.h     | 3 ++-
>>>   include/crypto/akcipher.h | 4 +++-
>>>   include/crypto/kpp.h      | 3 ++-
>>>   3 files changed, 7 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/include/crypto/aead.h b/include/crypto/aead.h
>>> index 0e8a41638678..cf212d28fe18 100644
>>> --- a/include/crypto/aead.h
>>> +++ b/include/crypto/aead.h
>>> @@ -10,6 +10,7 @@
>>>     #include <linux/atomic.h>
>>>   #include <linux/container_of.h>
>>> +#include <linux/overflow.h>
>>
>> You could move this 1 line below, to keep alphabetical order.
>> And why do you say that it is redundant in your follow-up mail?
> Thanks for your suggestion, I didn't notice this alphabetical order at 
> first :( .
> Because I found that  <linux/crypto.h> includes <linux/slab.h>, and
> <linux/slab.h> includes <linux/overflow.h>, so this overflow.h is 
> redundant.

It is usually considered best practice to include what is used, and not 
relying on indirect includes.

Should these others includes change one day, then some apparently 
unrelated files will fails to built.

CJ