linux-kernel - Re: [PATCH v2] media: atomisp: Remove compat ioctl32 header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeZy3+0bGCNKjzPaK1Y234ZnZtG7v5iygtF1+Uhm9bTEA@mail.gmail.com>
Date: Mon, 21 Apr 2025 12:02:43 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
Cc: andy@...nel.org, sakari.ailus@...ux.intel.com, 
	Hans de Goede <hdegoede@...hat.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, 
	linux-media@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2] media: atomisp: Remove compat ioctl32 header file

On Mon, Apr 21, 2025 at 8:28 AM Hardevsinh Palaniya
<hardevsinh.palaniya@...iconsignals.io> wrote:
>
> Arnd's patch [1] removed the compat ioctl32 code, so this
> header file is no longer needed.
>
> Additionally, the definition of atomisp_compat_ioctl32()
> was deleted in Arnd's patch [1], making its declaration
> unused as well.
>
> Moreover, there are no references to this header file or
> the function(atomisp_compat_ioctl32) in the atomisp codebase.

> Link URL[1]: https://lore.kernel.org/linux-media/20210614103409.3154127-7-arnd@kernel.org/

Not so literally :-)
Should be just

Link: https://lore.kernel.org/linux-media/20210614103409.3154127-7-arnd@kernel.org/
[1]

> Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>

Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andy@...nel.org>

P.S. No need to resend, I hope Hans can tweak this whilst applying.

-- 
With Best Regards,
Andy Shevchenko