linux-kernel - Re: [PATCH 4/7] arm64: dts: ti: k3-j721s2-common-proc-board: Add main

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a0bbbd1-4767-4399-b163-8243bd849bdf@ti.com>
Date: Mon, 21 Apr 2025 15:39:51 +0530
From: Jayesh Choudhary <j-choudhary@...com>
To: "Kumar, Udit" <u-kumar1@...com>, <nm@...com>, <vigneshr@...com>,
        <devarsht@...com>, <linux-kernel@...r.kernel.org>
CC: <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <kristo@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 4/7] arm64: dts: ti: k3-j721s2-common-proc-board: Add
 main_i2c4 instance

Hello Udit,

On 19/04/25 14:53, Kumar, Udit wrote:
> 
> On 4/11/2025 4:21 PM, Jayesh Choudhary wrote:
>> Add dt node for main_i2c4 instance along with required pinmuxing.
>> Also add the gpio expander 'exp4' required by display connector.
>>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
>> ---
>>   .../dts/ti/k3-j721s2-common-proc-board.dts    | 21 +++++++++++++++++++
>>   1 file changed, 21 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts 
>> b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> index e2fc1288ed07..f691ae4c19e6 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> @@ -148,6 +148,13 @@ J721S2_IOPAD(0x060, PIN_INPUT_PULLUP, 13) /* 
>> (AC27) MCASP2_AXR1.I2C3_SDA */
>>           >;
>>       };
>> +    main_i2c4_pins_default: main-i2c4-default-pins {
>> +        pinctrl-single,pins = <
>> +            J721S2_IOPAD(0x014, PIN_INPUT_PULLUP, 8) /* (AD25) 
>> I2C4_SCL */
>> +            J721S2_IOPAD(0x010, PIN_INPUT_PULLUP, 8) /* (AF28) 
>> I2C4_SDA */
>> +        >;
>> +    };
>> +
>>       main_i2c5_pins_default: main-i2c5-default-pins {
>>           pinctrl-single,pins = <
>>               J721S2_IOPAD(0x01c, PIN_INPUT, 8) /* (Y24) 
>> MCAN15_TX.I2C5_SCL */
>> @@ -370,6 +377,20 @@ exp2: gpio@22 {
>>       };
>>   };
>> +&main_i2c4 {
>> +    status = "okay";
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_i2c4_pins_default>;
>> +    clock-frequency = <400000>;
>> +
>> +    exp4: gpio@20 {
>> +        compatible = "ti,tca6408";
>> +        reg = <0x20>;
>> +        gpio-controller;
>> +        #gpio-cells = <2>;
> 
> I suggest to add, gpio-line-names as well for this gpio expander.
> 

Sure, I will add gpio-line-names.

> 
>> +    };
>> +};
>> +
>>   &main_i2c5 {
>>       pinctrl-names = "default";
>>       pinctrl-0 = <&main_i2c5_pins_default>;


Thanks,
Jayesh