linux-kernel - [PATCH 2/3] ext4: implement IOCB_DONTCACHE handling in write operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250421105026.19577-3-chentaotao@didiglobal.com>
Date: Mon, 21 Apr 2025 10:50:30 +0000
From: 陈涛涛 Taotao Chen <chentaotao@...iglobal.com>
To: "tytso@....edu" <tytso@....edu>, "adilger.kernel@...ger.ca"
	<adilger.kernel@...ger.ca>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "willy@...radead.org" <willy@...radead.org>
CC: "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	陈涛涛 Taotao Chen <chentaotao@...iglobal.com>
Subject: [PATCH 2/3] ext4: implement IOCB_DONTCACHE handling in write
 operations

From: Taotao Chen <chentaotao@...iglobal.com>

Implement IOCB_DONTCACHE flag handling in ext4 write paths:
1. Check IOCB_DONTCACHE flag passed via fsdata
2. Propagate FGP_DONTCACHE to page cache operations

Existing write behavior remains unchanged when IOCB_DONTCACHE is not set.

Signed-off-by: Taotao Chen <chentaotao@...iglobal.com>
---
 fs/ext4/inode.c | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 94c7d2d828a6..787dd152a47e 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -1147,16 +1147,22 @@ static int ext4_write_begin(struct file *file, struct address_space *mapping,
 {
 	struct inode *inode = mapping->host;
 	int ret, needed_blocks;
+	int iocb_flag;
 	handle_t *handle;
 	int retries = 0;
 	struct folio *folio;
 	pgoff_t index;
+	fgf_t fgp = FGP_WRITEBEGIN;
 	unsigned from, to;
 
 	ret = ext4_emergency_state(inode->i_sb);
 	if (unlikely(ret))
 		return ret;
 
+	iocb_flag = (int)(uintptr_t)(*fsdata);
+	if (iocb_flag & IOCB_DONTCACHE)
+		fgp |= FGP_DONTCACHE;
+
 	trace_ext4_write_begin(inode, pos, len);
 	/*
 	 * Reserve one block more for addition to orphan list in case
@@ -1184,7 +1190,7 @@ static int ext4_write_begin(struct file *file, struct address_space *mapping,
 	 * the folio (if needed) without using GFP_NOFS.
 	 */
 retry_grab:
-	folio = __filemap_get_folio(mapping, index, FGP_WRITEBEGIN,
+	folio = __filemap_get_folio(mapping, index, fgp,
 					mapping_gfp_mask(mapping));
 	if (IS_ERR(folio))
 		return PTR_ERR(folio);
@@ -2917,6 +2923,8 @@ static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
 			       struct folio **foliop, void **fsdata)
 {
 	int ret, retries = 0;
+	int iocb_flag;
+	fgf_t fgp = FGP_WRITEBEGIN;
 	struct folio *folio;
 	pgoff_t index;
 	struct inode *inode = mapping->host;
@@ -2928,10 +2936,15 @@ static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
 	index = pos >> PAGE_SHIFT;
 
 	if (ext4_nonda_switch(inode->i_sb) || ext4_verity_in_progress(inode)) {
+		ret = ext4_write_begin(file, mapping, pos, len, foliop, fsdata);
 		*fsdata = (void *)FALL_BACK_TO_NONDELALLOC;
-		return ext4_write_begin(file, mapping, pos,
-					len, foliop, fsdata);
+		return ret;
 	}
+
+	iocb_flag = (int)(uintptr_t)(*fsdata);
+	if (iocb_flag & IOCB_DONTCACHE)
+		fgp |= FGP_DONTCACHE;
+
 	*fsdata = (void *)0;
 	trace_ext4_da_write_begin(inode, pos, len);
 
@@ -2945,7 +2958,7 @@ static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
 	}
 
 retry:
-	folio = __filemap_get_folio(mapping, index, FGP_WRITEBEGIN,
+	folio = __filemap_get_folio(mapping, index, fgp,
 			mapping_gfp_mask(mapping));
 	if (IS_ERR(folio))
 		return PTR_ERR(folio);
-- 
2.34.1