linux-kernel - Re: [PATCH v3 0/3] Fix and refactor output disable logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250421123331.634076d5@jic23-huawei>
Date: Mon, 21 Apr 2025 12:33:31 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Gabriel Shahrouzi <gshahrouzi@...il.com>
Cc: gregkh@...uxfoundation.org, lars@...afoo.de, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
 Michael.Hennerich@...log.com, skhan@...uxfoundation.org,
 linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH v3 0/3] Fix and refactor output disable logic

On Sun, 20 Apr 2025 13:54:16 -0400
Gabriel Shahrouzi <gshahrouzi@...il.com> wrote:

> Patch 1 includes the initial fix.
> 
> Patch 2 refactors the code to use the out_altvoltage_powerdown ABI.
> 
> Patch 3 adds small improvements by minimizing the size of types and
> doing a redundancy check.
> 
> Not sure whether to include a read function for powerdown as well since
> all the other attributes only had write permissions. I can also do this
> for the other attributes to help modernize the driver.
> 
> Changes in v3:
> 	- Include version log in cover letter.
Just post it in reply to that v2!

Note though that this needs a rebase as I mentioned in the thread wrt to
the original fix. I'll take a quick look though to see if I can spot
anything else for v4.

> Changes in v2:
> 	- Refactor and make small improvements ontop of the initial fix.
> 
> Gabriel Shahrouzi (3):
>   iio: frequency: Use SLEEP bit instead of RESET to disable output
>   staging: iio: ad9832: Refactor powerdown control
>   staging: iio: ad9832: Add minor improvements to ad9832_write_powerdown
> 
>  drivers/staging/iio/frequency/ad9832.c | 50 ++++++++++++++++++--------
>  1 file changed, 36 insertions(+), 14 deletions(-)
>