linux-kernel - Re: [PATCH] powerpc/pseries/msi: Avoid reading PCI device registers in reduced power states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <pjuk4ckhtlpu2m6qykrpv6jw4eafymnarrpun4psn6yptogj2b@5ird52o5ml4p>
Date: Mon, 21 Apr 2025 17:20:08 +0530
From: Gautam Menghani <gautam@...ux.ibm.com>
To: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>
Cc: Vaibhav Jain <vaibhav@...ux.ibm.com>, maddy@...ux.ibm.com,
        mpe@...erman.id.au, npiggin@...il.com, christophe.leroy@...roup.eu,
        naveen@...nel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/pseries/msi: Avoid reading PCI device registers
 in reduced power states

Hi Venkat,

Thanks for the report. I looked into this and found that the new warning
you reported can be observed even on current distro kernels, and is not
caused by the patch I've posted.

I was able to observe the same warning with fedora distro kernel 6.13.7-200.fc41

[   70.294478] icp_hv_set_xirr: bad return code eoi xirr=0x50a0002 returned -4
[   70.294521] ------------[ cut here ]------------
[   70.294546] WARNING: CPU: 7 PID: 54 at arch/powerpc/sysdev/xics/icp-hv.c:55 icp_hv_eoi+0xf8/0x120
[   70.294599] Modules linked in: xt_conntrack xt_MASQUERADE bridge stp llc ip6table_nat ip6table_filter ip6_tables xt_set ip_set iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 xt_addrtype iptable_filter ip_tables kvm rpcrdma rdma_cm iw_cm ib_cm ib_core bonding overlay rfkill binfmt_misc vmx_crypto pseries_rng nfsd auth_rpcgss nfs_acl loop dm_multipath lockd grace nfs_localio nfnetlink vsock_loopback vmw_vsock_virtio_transport_common vsock xfs nvme_tcp nvme_fabrics nvme_keyring nvme_core nvme_auth ibmvscsi ibmveth scsi_transport_srp crct10dif_vpmsum crc32c_vpmsum pseries_wdt sunrpc be2iscsi bnx2i cnic uio cxgb4i cxgb4 tls cxgb3i cxgb3 mdio libcxgbi libcxgb qla4xxx iscsi_boot_sysfs iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi scsi_dh_rdac scsi_dh_emc scsi_dh_alua fuse aes_gcm_p10_crypto crypto_simd cryptd
[   70.295015] CPU: 7 UID: 0 PID: 54 Comm: ksoftirqd/7 Kdump: loaded Not tainted 6.13.7-200.fc41.ppc64le #1
[   70.295064] Hardware name: IBM,9080-HEX POWER8 (architected) 0x800200 0xf000004 of:IBM,FW1060.00 (NH1060_022) hv:phyp pSeries
[   70.295120] NIP:  c000000000197c98 LR: c000000000197c94 CTR: 0000000000000000
[   70.295157] REGS: c000000007dd3a20 TRAP: 0700   Not tainted  (6.13.7-200.fc41.ppc64le)
[   70.295197] MSR:  8000000002029033 <SF,VEC,EE,ME,IR,DR,RI,LE>  CR: 24004202  XER: 00000001
[   70.295247] CFAR: c00000000032731c IRQMASK: 1
[   70.295247] GPR00: c000000000197c94 c000000007dd3cc0 c0000000024daa00 000000000000003f
[   70.295247] GPR04: 00000000ffff7fff 00000000ffff7fff c000000007dd3ae8 00000007ec8e0000
[   70.295247] GPR08: 0000000000000027 0000000000000000 0000000000000000 0000000000004000
[   70.295247] GPR12: 0000000000000000 c00000000ffc6f00 c000000000287ef8 c000000004a51080
[   70.295247] GPR16: 0000000000000000 0000000004208040 c000000003d62c80 c0000000031faf80
[   70.295247] GPR20: 00000000ffffa63b 000000000000000a c0000000031e6990 c000000000335f10
[   70.295247] GPR24: 0000000000000001 0000000000000000 0000000000000006 0000000000000002
[   70.295247] GPR28: c0000007efac68b8 0000000000000000 00000000050a0002 00000000050a0002
[   70.295603] NIP [c000000000197c98] icp_hv_eoi+0xf8/0x120
[   70.295633] LR [c000000000197c94] icp_hv_eoi+0xf4/0x120
[   70.295661] Call Trace:
[   70.295675] [c000000007dd3cc0] [c000000000197c94] icp_hv_eoi+0xf4/0x120 (unreliable)
[   70.295717] [c000000007dd3d40] [c000000000337a5c] handle_fasteoi_irq+0x16c/0x350
[   70.295757] [c000000007dd3d70] [c000000000335fd0] resend_irqs+0xc0/0x190
[   70.295793] [c000000007dd3db0] [c000000000254064] tasklet_action_common+0x154/0x440
[   70.295833] [c000000007dd3e20] [c000000000253458] handle_softirqs+0x168/0x4f0
[   70.295871] [c000000007dd3f10] [c000000000253848] run_ksoftirqd+0x68/0xb0
[   70.295912] [c000000007dd3f30] [c000000000292f20] smpboot_thread_fn+0x1d0/0x240
[   70.295951] [c000000007dd3f90] [c000000000288020] kthread+0x130/0x140
[   70.295984] [c000000007dd3fe0] [c00000000000ded8] start_kernel_thread+0x14/0x18
[   70.296022] Code: 48c84251 60000000 e9210068 4bffff98 7c661b78 3c82ff31 3c62ff7d 7fc5f378 38842b40 38639bf8 4818f649 60000000 <0fe00000> 38210080 7be34622 e8010010
[   70.296104] ---[ end trace 0000000000000000 ]---
[   70.297273] PM: resume devices took 0.000 seconds
[   70.297415] OOM killer enabled.
[   70.297433] Restarting tasks ... done.
[   70.298959] random: crng reseeded on system resumption
[   70.299106] PM: suspend exit


This can be tracked as a separate bug, as it is unrelated to the patch.

Thanks,
Gautam