[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <59895b61-9d63-9d60-63da-5524b4dcfe2b@loongson.cn>
Date: Mon, 21 Apr 2025 08:50:55 +0800
From: bibo mao <maobibo@...ngson.cn>
To: WangYuli <wangyuli@...ontech.com>, Yulong Han <wheatfox17@...oud.com>,
zhaotianrui@...ngson.cn, Huacai Chen <chenhuacai@...nel.org>,
WANG Xuerui <kernel@...0n.name>
Cc: loongarch@...ts.linux.dev, Xianglai Li <lixianglai@...ngson.cn>,
Min Zhou <zhoumin@...ngson.cn>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Fixed multiple typos of KVM code
Yulong,
Sorry for the late response, I do not notice this until reply from Yuli.
Thanks for patch.
Reviewed-by: Bibo Mao <maobibo@...ngson.cn>
On 2025/4/20 下午11:40, WangYuli wrote:
> [ Expanded the recipient list. ]
>
> Hi Yulong,
>
> On 2025/4/20 22:22, Yulong Han wrote:
>> Fixed multiple typos inside arch/loongarch/kvm.
>>
>> Signed-off-by: Yulong Han <wheatfox17@...oud.com>
>> ---
>> arch/loongarch/kvm/intc/ipi.c | 4 ++--
>> arch/loongarch/kvm/main.c | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/loongarch/kvm/intc/ipi.c
>> b/arch/loongarch/kvm/intc/ipi.c
>> index 93f4acd44..fe734dc06 100644
>> --- a/arch/loongarch/kvm/intc/ipi.c
>> +++ b/arch/loongarch/kvm/intc/ipi.c
>> @@ -111,7 +111,7 @@ static int send_ipi_data(struct kvm_vcpu *vcpu,
>> gpa_t addr, uint64_t data)
>> ret = kvm_io_bus_read(vcpu, KVM_IOCSR_BUS, addr,
>> sizeof(val), &val);
>> srcu_read_unlock(&vcpu->kvm->srcu, idx);
>> if (unlikely(ret)) {
>> - kvm_err("%s: : read date from addr %llx failed\n",
>> __func__, addr);
>> + kvm_err("%s: : read data from addr %llx failed\n",
>> __func__, addr);
>> return ret;
>> }
>> /* Construct the mask by scanning the bit 27-30 */
>> @@ -127,7 +127,7 @@ static int send_ipi_data(struct kvm_vcpu *vcpu,
>> gpa_t addr, uint64_t data)
>> ret = kvm_io_bus_write(vcpu, KVM_IOCSR_BUS, addr, sizeof(val),
>> &val);
>> srcu_read_unlock(&vcpu->kvm->srcu, idx);
>> if (unlikely(ret))
>> - kvm_err("%s: : write date to addr %llx failed\n", __func__,
>> addr);
>> + kvm_err("%s: : write data to addr %llx failed\n", __func__,
>> addr);
>> return ret;
>> }
>> diff --git a/arch/loongarch/kvm/main.c b/arch/loongarch/kvm/main.c
>> index d165cd38c..80ea63d46 100644
>> --- a/arch/loongarch/kvm/main.c
>> +++ b/arch/loongarch/kvm/main.c
>> @@ -296,10 +296,10 @@ int kvm_arch_enable_virtualization_cpu(void)
>> /*
>> * Enable virtualization features granting guest direct control of
>> * certain features:
>> - * GCI=2: Trap on init or unimplement cache instruction.
>> + * GCI=2: Trap on init or unimplemented cache instruction.
>> * TORU=0: Trap on Root Unimplement.
>> * CACTRL=1: Root control cache.
>> - * TOP=0: Trap on Previlege.
>> + * TOP=0: Trap on Privilege.
>> * TOE=0: Trap on Exception.
>> * TIT=0: Trap on Timer.
>> */
> Reviewed-by: Yuli Wang <wangyuli@...ontech.com>
>
> Please note that if you wish for a timely response to your patch, you
> should ensure that all maintainers output by ./scripts/get_maintainer.pl
> and the relevant open mailing lists are fully present in your recipient
> list.
>
> Thanks,
Powered by blists - more mailing lists