| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250421140836.GH2789685@horms.kernel.org>
Date: Mon, 21 Apr 2025 15:08:36 +0100
From: Simon Horman <horms@...nel.org>
To: Larysa Zaremba <larysa.zaremba@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org,
Tony Nguyen <anthony.l.nguyen@...el.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jonathan Corbet <corbet@....net>,
Przemek Kitszel <przemyslaw.kitszel@...el.com>,
Jiri Pirko <jiri@...nulli.us>,
Mustafa Ismail <mustafa.ismail@...el.com>,
Tatyana Nikolova <tatyana.e.nikolova@...el.com>,
Andrew Lunn <andrew+netdev@...n.ch>,
Alexander Lobakin <aleksander.lobakin@...el.com>,
Michael Ellerman <mpe@...erman.id.au>,
Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
Lee Trager <lee@...ger.us>,
Madhavan Srinivasan <maddy@...ux.ibm.com>,
Sridhar Samudrala <sridhar.samudrala@...el.com>,
Jacob Keller <jacob.e.keller@...el.com>,
Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
Mateusz Polchlopek <mateusz.polchlopek@...el.com>,
Wenjun Wu <wenjun1.wu@...el.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
netdev@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org,
"Karlsson, Magnus" <magnus.karlsson@...el.com>,
Emil Tantilov <emil.s.tantilov@...el.com>,
Madhu Chittim <madhu.chittim@...el.com>,
Josh Hay <joshua.a.hay@...el.com>,
Milena Olech <milena.olech@...el.com>, pavan.kumar.linga@...el.com,
"Singhai, Anjali" <anjali.singhai@...el.com>,
Phani R Burra <phani.r.burra@...el.com>
Subject: Re: [PATCH iwl-next 03/14] libeth: add PCI device initialization
helpers to libeth
On Tue, Apr 08, 2025 at 02:47:49PM +0200, Larysa Zaremba wrote:
> From: Phani R Burra <phani.r.burra@...el.com>
>
> Add memory related support functions for drivers to access MMIO space and
> allocate/free dma buffers.
>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Signed-off-by: Phani R Burra <phani.r.burra@...el.com>
> Co-developed-by: Victor Raj <victor.raj@...el.com>
> Signed-off-by: Victor Raj <victor.raj@...el.com>
> Co-developed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Co-developed-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
> Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
> Co-developed-by: Larysa Zaremba <larysa.zaremba@...el.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
...
> diff --git a/drivers/net/ethernet/intel/libeth/pci.c b/drivers/net/ethernet/intel/libeth/pci.c
...
> +/**
> + * __libeth_pci_map_mmio_region - map PCI device MMIO region
> + * @mmio_info: struct to store the mapped MMIO region
> + * @offset: MMIO region start offset
> + * @size: MMIO region size
> + * @num_args: number of additional arguments present
> + *
> + * Return: true on success, false on memory map failure.
> + */
> +bool __libeth_pci_map_mmio_region(struct libeth_mmio_info *mmio_info,
> + resource_size_t offset,
> + resource_size_t size, int num_args, ...)
> +{
> + struct pci_dev *pdev = mmio_info->pdev;
> + struct libeth_pci_mmio_region *mr;
> + resource_size_t pa;
> + void __iomem *va;
> + int bar_idx = 0;
> + va_list args;
> +
> + if (num_args) {
> + va_start(args, num_args);
> + bar_idx = va_arg(args, int);
> + va_end(args);
> + }
> +
> + mr = libeth_find_mmio_region(&mmio_info->mmio_list, offset, bar_idx);
> + if (mr) {
> + pci_warn(pdev, "Mapping of BAR%u with offset %llu already exists\n",
> + bar_idx, offset);
Hi Phani, Larysa, all,
I think that the format specifier here should be %zu rather than %llu.
On ARM W=1 builds gcc 14.2.0 flags this as follows:
CALL scripts/checksyscalls.sh
CC drivers/net/ethernet/intel/libeth/pci.o
In file included from ./include/linux/device.h:15,
from ./include/linux/pci.h:37,
from ./include/net/libeth/pci.h:7,
from drivers/net/ethernet/intel/libeth/pci.c:4:
.../pci.c: In function '__libeth_pci_map_mmio_region':
.../pci.c:92:32: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
92 | pci_warn(pdev, "Mapping of BAR%u with offset %llu already exists\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
.../dev_printk.h:156:61: note: in expansion of macro 'dev_fmt'
156 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
.../pci.h:2704:41: note: in expansion of macro 'dev_warn'
2704 | #define pci_warn(pdev, fmt, arg...) dev_warn(&(pdev)->dev, fmt, ##arg)
| ^~~~~~~~
.../pci.c:92:17: note: in expansion of macro 'pci_warn'
92 | pci_warn(pdev, "Mapping of BAR%u with offset %llu already exists\n",
| ^~~~~~~~
.../pci.c:92:65: note: format string is defined here
92 | pci_warn(pdev, "Mapping of BAR%u with offset %llu already exists\n",
| ~~~^
| |
| long long unsigned int
| %u
Powered by blists - more mailing lists