linux-kernel - Re: [PATCH v12 3/9] kexec: define functions to map and unmap segments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef18ae186cd17431b9ff6b8a443b63fd6fb78b98.camel@linux.ibm.com>
Date: Mon, 21 Apr 2025 10:18:21 -0400
From: Mimi Zohar <zohar@...ux.ibm.com>
To: Baoquan He <bhe@...hat.com>, steven chen <chenste@...ux.microsoft.com>
Cc: stefanb@...ux.ibm.com, roberto.sassu@...weicloud.com,
        roberto.sassu@...wei.com, eric.snowberg@...cle.com,
        ebiederm@...ssion.com, paul@...l-moore.com, code@...icks.com,
        bauermann@...abnow.com, linux-integrity@...r.kernel.org,
        kexec@...ts.infradead.org, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, madvenka@...ux.microsoft.com,
        nramas@...ux.microsoft.com, James.Bottomley@...senpartnership.com,
        vgoyal@...hat.com, dyoung@...hat.com
Subject: Re: [PATCH v12 3/9] kexec: define functions to map and unmap
 segments

On Mon, 2025-04-21 at 09:51 -0400, Mimi Zohar wrote:
> On Fri, 2025-04-18 at 12:36 +0800, Baoquan He wrote:
> > On 04/15/25 at 07:10pm, steven chen wrote:
> > > From: Steven Chen <chenste@...ux.microsoft.com>
> >  ^^^^^^
> 
> As James Bottomley previously explained[1], if you haven't made any changes to
> Tushar's patch, then the very first line of the patch description would be
> "From: Tushar Sugandhi <tusharsu@...ux.microsoft.com>" followed by a blank line.
> If there is a minor change, you would add "<your email address>: explanation".
> For example:
> 
> Steven Chen <chenste@...ux.microsoft.com>: modified patch description

To clarify: This line would be included below with your Signed-off-by tag.

> 
> [1]
> https://lore.kernel.org/lkml/58e70121aaee33679ac295847197c1e5511b2a81.camel@HansenPartnership.com/
> 
> > > 
> > > Implement kimage_map_segment() to enable IMA to map the measurement log 
> > > list to the kimage structure during the kexec 'load' stage. This function
> > > gathers the source pages within the specified address range, and maps them
> > > to a contiguous virtual address range.
> > > 
> > > This is a preparation for later usage.
> > > 
> > > Implement kimage_unmap_segment() for unmapping segments using vunmap().
> > > 
> > > From: Tushar Sugandhi <tusharsu@...ux.microsoft.com>
> >   ^^^^^^
> 
> Neither "Author:" nor "From:" belong here.  Please remove.
> 
> > > Signed-off-by: Tushar Sugandhi <tusharsu@...ux.microsoft.com>
> >   ^^^^^^^
> 
> Having Tushar's "Signed-off-by" tag and yours below indicate that you modified
> the original author's patch.

To clarify: "Just" having Tushar's "Signed-off-by" tag and yours below indicate
that you modified the original author's patch.

> 
> > > Cc: Eric Biederman <ebiederm@...ssion.com>
> > > Cc: Baoquan He <bhe@...hat.com> 
> > > Cc: Vivek Goyal <vgoyal@...hat.com>
> > > Cc: Dave Young <dyoung@...hat.com>
> > > Signed-off-by: steven chen <chenste@...ux.microsoft.com>
> >   ^^^^^
> > 
> > The signing on this patch is a little confusing. I can't see who is the
> > real author, who is the co-author, between you and Tushar. You may need
> > to refer to Documentation/process/5.Posting.rst to make that clear.
> > 
> > > Acked-by: Baoquan He <bhe@...hat.com>