linux-kernel - Re: [PATCH] nvme/pci: make PRP list DMA pools per-NUMA-node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAZV04hiWIz2UT2E@kbusch-mbp.dhcp.thefacebook.com>
Date: Mon, 21 Apr 2025 08:27:31 -0600
From: Keith Busch <kbusch@...nel.org>
To: Kanchan Joshi <joshi.k@...sung.com>
Cc: Caleb Sander Mateos <csander@...estorage.com>,
	Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
	Sagi Grimberg <sagi@...mberg.me>, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme/pci: make PRP list DMA pools per-NUMA-node

On Mon, Apr 21, 2025 at 12:43:24PM +0530, Kanchan Joshi wrote:
> On 4/20/2025 10:14 PM, Caleb Sander Mateos wrote:
> > struct nvme_dev {
> >   	struct nvme_queue *queues;
> >   	struct blk_mq_tag_set tagset;
> >   	struct blk_mq_tag_set admin_tagset;
> >   	u32 __iomem *dbs;
> >   	struct device *dev;
> > -	struct dma_pool *prp_page_pool;
> > -	struct dma_pool *prp_small_pool;
> > +	struct nvme_prp_dma_pools prp_pools[MAX_NUMNODES];
> 
> I wonder if it is worth to make this dynamic using nr_node_ids?

Yeah, I think so. MAX_NUMNODES is derived from a config value that may
be much larger than what the platform actually has.