linux-kernel - Re: [PATCH net-next v1 1/4] net: selftests: drop test index from net_selftest_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250421143325.GM2789685@horms.kernel.org>
Date: Mon, 21 Apr 2025 15:33:25 +0100
From: Simon Horman <horms@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v1 1/4] net: selftests: drop test index from
 net_selftest_get_strings()

On Wed, Apr 16, 2025 at 06:14:36PM +0200, Oleksij Rempel wrote:
> The test index is redundant and reduces available space for test names,
> which are already limited to ETH_GSTRING_LEN (32 bytes). Removing the
> index improves readability in tools like `ethtool -t`, especially when
> longer test names are used.
> 
> Before this change:
>   3. PHY internal loopback, enab
>   7. PHY internal loopback, disa
> 
> After this change:
>   PHY internal loopback, enable
>   PHY internal loopback, disable
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Simon Horman <horms@...nel.org>