linux-kernel - Re: [PATCH] delayacct: use macro to simplify delayacct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4df6a61-f70b-4b79-9494-ddc571382674@linux.dev>
Date: Mon, 21 Apr 2025 10:44:41 +0800
From: Ye Liu <ye.liu@...ux.dev>
To: yang.yang29@....com.cn
Cc: bsingharora@...il.com, linux-kernel@...r.kernel.org, liuye@...inos.cn,
 linux-mm@...ck.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] delayacct: use macro to simplify delayacct_end calls


在 2025/4/20 11:58, yang.yang29@....com.cn 写道:
> Hi Ye Liu
>
>> Replace repetitive calls to delayacct_end() with a new macro
>> DELAYACCT_END to reduce code duplication.
>> No functional changes.
> Please CC akpm@...ux-foundation.org and linux-mm@...ck.org
> next time.
>
> I think it's a good idea to use macros to reduce code duplication in
> functions. So what about also use macros to define
> void __delayacct_##type##_end().

Most functions can be replaced with macros, but considering that the
parameters of __delayacct_thrashing_end in this batch of functions are
inconsistent, is it worth using macro definitions only for other
functions? Or do you have any good ideas?

void __delayacct_blkio_end(struct task_struct *p)
void __delayacct_freepages_end(void)
void __delayacct_thrashing_end(bool *in_thrashing)
void __delayacct_swapin_end(void)                                     
void __delayacct_compact_end(void)
void __delayacct_wpcopy_end(void)

Thanks,
Ye Liu

> Thanks!