linux-kernel - Re: [PATCH v1 07/16] iommufd/viommu: Add driver-allocated vDEVICE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAZlujUAJ6tWekEA@Asurada-Nvidia>
Date: Mon, 21 Apr 2025 08:35:22 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: "Tian, Kevin" <kevin.tian@...el.com>
CC: "jgg@...dia.com" <jgg@...dia.com>, "corbet@....net" <corbet@....net>,
	"will@...nel.org" <will@...nel.org>, "robin.murphy@....com"
	<robin.murphy@....com>, "joro@...tes.org" <joro@...tes.org>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>, "vdumpa@...dia.com"
	<vdumpa@...dia.com>, "jonathanh@...dia.com" <jonathanh@...dia.com>,
	"shuah@...nel.org" <shuah@...nel.org>, "praan@...gle.com" <praan@...gle.com>,
	"nathan@...nel.org" <nathan@...nel.org>, "peterz@...radead.org"
	<peterz@...radead.org>, "Liu, Yi L" <yi.l.liu@...el.com>,
	"jsnitsel@...hat.com" <jsnitsel@...hat.com>, "mshavit@...gle.com"
	<mshavit@...gle.com>, "zhangzekun11@...wei.com" <zhangzekun11@...wei.com>,
	"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v1 07/16] iommufd/viommu: Add driver-allocated vDEVICE
 support

On Mon, Apr 21, 2025 at 08:00:37AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@...dia.com>
> > Sent: Friday, April 11, 2025 2:38 PM
> > 
> > @@ -128,6 +142,9 @@ struct iommufd_viommu_ops {
> >  		const struct iommu_user_data *user_data);
> >  	int (*cache_invalidate)(struct iommufd_viommu *viommu,
> >  				struct iommu_user_data_array *array);
> > +	struct iommufd_vdevice *(*vdevice_alloc)(struct iommufd_viommu
> > *viommu,
> > +						 struct device *dev, u64 id);
> 
> s/id/virt_id/ would be clearer.

OK.

@@ -143,7 +143,8 @@ struct iommufd_viommu_ops {
        int (*cache_invalidate)(struct iommufd_viommu *viommu,
                                struct iommu_user_data_array *array);
        struct iommufd_vdevice *(*vdevice_alloc)(struct iommufd_viommu *viommu,
-                                                struct device *dev, u64 id);
+                                                struct device *dev,
+                                                u64 virt_id);
        void (*vdevice_destroy)(struct iommufd_vdevice *vdev);
 };


Thanks
Nicolin