linux-kernel - Re: [PATCH v3 1/3] dt-bindings: net: Add support for rk3562 dwmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18705cc3-ef2c-49f4-b284-bca2308950f9@kwiboo.se>
Date: Mon, 21 Apr 2025 18:25:05 +0200
From: Jonas Karlman <jonas@...boo.se>
To: Kever Yang <kever.yang@...k-chips.com>, "heiko@...ech.de"
 <heiko@...ech.de>
Cc: "linux-rockchip@...ts.infradead.org"
 <linux-rockchip@...ts.infradead.org>,
 Conor Dooley <conor.dooley@...rochip.com>, Jose Abreu
 <joabreu@...opsys.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Giuseppe Cavallaro <peppe.cavallaro@...com>, Rob Herring <robh@...nel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, David Wu <david.wu@...k-chips.com>,
 Paolo Abeni <pabeni@...hat.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Eric Dumazet
 <edumazet@...gle.com>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: net: Add support for rk3562 dwmac

Hi Kever,

On 2025-04-18 11:51, Kever Yang wrote:
> Add a rockchip,rk3562-gmac compatible for supporting the 2 gmac
> devices on the rk3562.
> rk3562 only has 4 clocks available for gmac module.
> 
> Signed-off-by: Kever Yang <kever.yang@...k-chips.com>
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> 
> Changes in v3:
> - Collect ack tag
> - rebase to v6.15-rc1
> 
> Changes in v2:
> - Fix schema entry and add clocks minItem change
> 
>  Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 3 +++
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml     | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index 0ac7c4b47d6b..a0814e807bd5 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -25,6 +25,7 @@ select:
>            - rockchip,rk3368-gmac
>            - rockchip,rk3399-gmac
>            - rockchip,rk3528-gmac
> +          - rockchip,rk3562-gmac
>            - rockchip,rk3568-gmac
>            - rockchip,rk3576-gmac
>            - rockchip,rk3588-gmac
> @@ -51,6 +52,7 @@ properties:
>        - items:
>            - enum:
>                - rockchip,rk3528-gmac
> +              - rockchip,rk3562-gmac
>                - rockchip,rk3568-gmac
>                - rockchip,rk3576-gmac
>                - rockchip,rk3588-gmac
> @@ -149,6 +151,7 @@ allOf:
>              contains:
>                enum:
>                  - rockchip,rk3528-gmac
> +                - rockchip,rk3562-gmac
>      then:
>        properties:
>          clocks:
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 78b3030dc56d..7498bcad895a 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -83,6 +83,7 @@ properties:
>          - rockchip,rk3328-gmac
>          - rockchip,rk3366-gmac
>          - rockchip,rk3368-gmac
> +        - rockchip,rk3562-gmac

This compatible does not need to be added in snps,dwmac.yaml because
snps,dwmac-4.20a is already listed in this file.

Regards,
Jonas

>          - rockchip,rk3576-gmac
>          - rockchip,rk3588-gmac
>          - rockchip,rk3399-gmac