linux-kernel - Re: [PATCH v2 2/2] nvme/pci: make PRP list DMA pools per-NUMA-node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAZzd-9YjBP4IyNK@kbusch-mbp.dhcp.thefacebook.com>
Date: Mon, 21 Apr 2025 10:33:59 -0600
From: Keith Busch <kbusch@...nel.org>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
	Sagi Grimberg <sagi@...mberg.me>,
	Kanchan Joshi <joshi.k@...sung.com>, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] nvme/pci: make PRP list DMA pools per-NUMA-node

On Mon, Apr 21, 2025 at 10:17:25AM -0600, Caleb Sander Mateos wrote:
> +static void nvme_release_prp_pools(struct nvme_dev *dev)
> +{
> +	struct nvme_prp_dma_pools *pools_end = dev->prp_pools + nr_node_ids;
> +	struct nvme_prp_dma_pools *prp_pools;
> +
> +	for (prp_pools = dev->prp_pools; prp_pools < pools_end; prp_pools++) {
> +		if (!prp_pools->small)
> +			continue;
> +
> +		dma_pool_destroy(prp_pools->large);
> +		dma_pool_destroy(prp_pools->small);
> +	}
> +}

A minor difference in style, I think indexing looks cleaner than
incrementing pointers: 

static void nvme_release_prp_pools(struct nvme_dev *dev)
{
	int i;

	for (i = 0; i < nr_node_ids; i++) {
		dma_pool_destroy(dev->prp_pools[i].small);
		dma_pool_destroy(dev->prp_pools[i].large);
	}
}

Note, dma_pool_destroy() already checks for NULL, so no need to check
before calling it.